Addresses a bug with plugins.security.allow_unsafe_democertificates setting
#4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
requested review from
cliu123,
cwperks,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Expand to see the expected error log: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4600 +/- ##
==========================================
+ Coverage 65.25% 65.29% +0.03%
==========================================
Files 317 317
Lines 22272 22277 +5
Branches 3582 3582
==========================================
+ Hits 14534 14545 +11
+ Misses 5946 5941 -5
+ Partials 1792 1791 -1
|
cwperks
approved these changes
Jul 25, 2024
shikharj05
approved these changes
Jul 26, 2024
stephen-crawford
approved these changes
Jul 26, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
… setting (#4600) Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 004d07b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
terryquigleysas
pushed a commit
to terryquigleysas/security
that referenced
this pull request
Jul 27, 2024
… setting (opensearch-project#4600) Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Terry Quigley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a bug where mismatching demo certificate hashes caused the setting
plugins.security.allow_unsafe_democertificatesto not work as expected.Category : Bug fix
Why these changes are required?
Without this PR, the setting
plugins.security.allow_unsafe_democertificateswill not work.What is the old behavior before changes and new behavior after changes?
Before: Cluster fails to not boot up when setting is set to true
After: Cluster fails to boot up
Issues Resolved
plugins.security.allow_unsafe_democertificatessetting is not working as expected #4599Testing
Unit testing, Manual Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.