-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add can trip circuit breaker override #4697
Add can trip circuit breaker override #4697
Conversation
Signed-off-by: Derek Ho <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4697 +/- ##
==========================================
- Coverage 67.98% 67.94% -0.05%
==========================================
Files 310 310
Lines 20924 20927 +3
Branches 3318 3322 +4
==========================================
- Hits 14225 14218 -7
- Misses 4951 4958 +7
- Partials 1748 1751 +3
|
Thank you @derek-ho. This looks like an innocuous change that would enhance the security of a cluster. For instance, if a cluster has a single user eating up resources, this change will ensure that an admin can take actions to mitigate w/o running into the circuit breaker. |
Agree! Are there any APIs not covered by this that you think should also not trip the circuit breaker? |
No, I think this single change in the Abstract class covers the most important endpoints around internalusers, roles, roles mappings, etc. |
49cdcb4
into
opensearch-project:main
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 49cdcb4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Adds override that security APIs should not trip the circuit breaker
Issues Resolved
Fix: #4687
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failed
label from the original PR.No
Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
No
Testing
None
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.