-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename auth failure listeners & add permission support #4713
Merged
cwperks
merged 2 commits into
opensearch-project:main
from
derek-ho:auth-failure-listener-follow-up
Sep 12, 2024
Merged
Rename auth failure listeners & add permission support #4713
cwperks
merged 2 commits into
opensearch-project:main
from
derek-ho:auth-failure-listener-follow-up
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
cwperks,
DarshitChanpura,
nibix,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
September 6, 2024 16:06
derek-ho
commented
Sep 6, 2024
src/main/java/org/opensearch/security/dlic/rest/api/RestApiAdminPrivilegesEvaluator.java
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4713 +/- ##
==========================================
+ Coverage 65.22% 65.53% +0.30%
==========================================
Files 318 319 +1
Lines 22327 22446 +119
Branches 3591 3601 +10
==========================================
+ Hits 14562 14709 +147
+ Misses 5968 5929 -39
- Partials 1797 1808 +11
|
derek-ho
commented
Sep 6, 2024
src/main/java/org/opensearch/security/dlic/rest/api/RateLimitersApiAction.java
Show resolved
Hide resolved
cwperks
reviewed
Sep 6, 2024
src/main/java/org/opensearch/security/dlic/rest/api/RestApiAdminPrivilegesEvaluator.java
Show resolved
Hide resolved
Signed-off-by: Derek Ho <[email protected]>
willyborankin
approved these changes
Sep 12, 2024
cwperks
approved these changes
Sep 12, 2024
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-4713-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c6988fb50ac3847b526529841775efa2cba0bfb5
# Push it to GitHub
git push --set-upstream origin backport/backport-4713-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
tmanninger
pushed a commit
to tmanninger/opensearch-security
that referenced
this pull request
Sep 24, 2024
…oject#4713) Signed-off-by: Derek Ho <[email protected]> Signed-off-by: tmanninger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames auth failure listener classes & APIs to a more general name (rate limiters) to support API tokens & other use cases. Adds permission support to these APIs. Removes incorrect debug logging.
Enhancement
Fix: [BUG] Auth Failure Listener API follow ups #4712
New class names, API routes, permission support, before: none of the above.
Issues Resolved
Fix: #4712
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failed
label from the original PR.No
Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
No
Testing
Existing tests pass
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.