Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SHOW and DESCRIBE queries. #85

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

Yury-Fridlyand
Copy link
Collaborator

Description

As of opensearch-project/sql#1181, SHOW and DESCRIBE queries syntax changed in V2. These query were falling back to V1 SQL plugin engine, which would be deprecated once upon a time. Updating this query in JDBC driver ensures that SQL plugin would properly respond to it.
See similar fix in ODBC: opensearch-project/sql-odbc#48.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@GumpacG
Copy link
Collaborator

GumpacG commented Jun 7, 2023

Are these changes related to test failures? Tests may also need to get updated.

Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Copy link
Collaborator Author

Thank you for pointing this out, I had a mistake. Should be fixed now.

@MaxKsyunz MaxKsyunz merged commit bc04675 into opensearch-project:main Jun 13, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the update-test-query branch June 13, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants