Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize development documentation #1092

Closed
wants to merge 1 commit into from

Conversation

dai-chen
Copy link
Collaborator

Signed-off-by: Chen Dai [email protected]

Description

TODO

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen dai-chen added the documentation Improvements or additions to documentation label Nov 21, 2022
@dai-chen dai-chen self-assigned this Nov 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2022

Codecov Report

Merging #1092 (a97dbd3) into 2.x (81c9285) will decrease coverage by 2.52%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #1092      +/-   ##
============================================
- Coverage     98.27%   95.75%   -2.53%     
- Complexity     3434     3450      +16     
============================================
  Files           343      355      +12     
  Lines          8540     9238     +698     
  Branches        544      666     +122     
============================================
+ Hits           8393     8846     +453     
- Misses          142      334     +192     
- Partials          5       58      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.28% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/opensearch/sql/analysis/Analyzer.java 100.00% <0.00%> (ø)
...java/org/opensearch/sql/ppl/parser/AstBuilder.java 100.00% <0.00%> (ø)
...expression/function/BuiltinFunctionRepository.java 100.00% <0.00%> (ø)
...l/prometheus/storage/PrometheusStorageFactory.java 100.00% <0.00%> (ø)
...l/planner/physical/catalog/CatalogTableSchema.java
...sql/planner/physical/catalog/CatalogTableScan.java
.../analysis/CatalogSchemaIdentifierNameResolver.java
...rch/sql/planner/physical/catalog/CatalogTable.java
...alysis/DataSourceSchemaIdentifierNameResolver.java 100.00% <0.00%> (ø)
...anner/physical/datasource/DataSourceTableScan.java 100.00% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@MaxKsyunz MaxKsyunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dai-chen where did the content in expression-pushdown.md originate?
It looks like it was written before V2 engine was added.

@dai-chen
Copy link
Collaborator Author

@dai-chen where did the content in expression-pushdown.md originate? It looks like it was written before V2 engine was added.

Hi @MaxKsyunz It is part of the V2 engine from internal design documentation. I'm trying to make this kind of doc public in this PR as well.

@MaxKsyunz
Copy link
Collaborator

@dai-chen where did the content in expression-pushdown.md originate? It looks like it was written before V2 engine was added.

Hi @MaxKsyunz It is part of the V2 engine from internal design documentation. I'm trying to make this kind of doc public in this PR as well.

Much appreciated @dai-chen. Thank you!

@dai-chen
Copy link
Collaborator Author

Default branch was changed. Will raise new PR after rebase.

@dai-chen dai-chen closed this Dec 20, 2022
@dai-chen dai-chen mentioned this pull request Dec 20, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Planned work items
Development

Successfully merging this pull request may close these issues.

3 participants