Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table write operator and builder #1094

Merged
merged 5 commits into from
Dec 14, 2022

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented Nov 22, 2022

Description

Similarly as #1091, add new TableWriteBuilder as transition state between logical write and physical write operator.

optimizer-Page-2

Issues Resolved

#1093

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen dai-chen added the enhancement New feature or request label Nov 22, 2022
@dai-chen dai-chen self-assigned this Nov 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #1094 (55f3ecd) into 2.x (64a3794) will decrease coverage by 2.48%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #1094      +/-   ##
============================================
- Coverage     98.30%   95.82%   -2.49%     
- Complexity     3503     3535      +32     
============================================
  Files           340      356      +16     
  Lines          8652     9378     +726     
  Branches        550      673     +123     
============================================
+ Hits           8505     8986     +481     
- Misses          142      334     +192     
- Partials          5       58      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.31% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ch/sql/planner/optimizer/LogicalPlanOptimizer.java 100.00% <ø> (ø)
...org/opensearch/sql/planner/DefaultImplementor.java 100.00% <100.00%> (ø)
...opensearch/sql/planner/logical/LogicalPlanDSL.java 100.00% <100.00%> (ø)
...ch/sql/planner/logical/LogicalPlanNodeVisitor.java 100.00% <100.00%> (ø)
...g/opensearch/sql/planner/logical/LogicalWrite.java 100.00% <100.00%> (ø)
...search/sql/planner/optimizer/pattern/Patterns.java 100.00% <100.00%> (ø)
.../optimizer/rule/write/CreateTableWriteBuilder.java 100.00% <100.00%> (ø)
.../sql/planner/physical/PhysicalPlanNodeVisitor.java 100.00% <100.00%> (ø)
...rc/main/java/org/opensearch/sql/storage/Table.java 100.00% <100.00%> (ø)
...pensearch/sql/storage/write/TableWriteBuilder.java 100.00% <100.00%> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen marked this pull request as ready for review December 8, 2022 04:47
@dai-chen dai-chen requested a review from a team as a code owner December 8, 2022 04:47
@dai-chen dai-chen merged commit c494d92 into opensearch-project:2.x Dec 14, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 14, 2022
* Add table write operator and builder

Signed-off-by: Chen Dai <[email protected]>

* Add UT for all new classes

Signed-off-by: Chen Dai <[email protected]>

* Rename child field

Signed-off-by: Chen Dai <[email protected]>

* Add columns field

Signed-off-by: Chen Dai <[email protected]>

* Update javadoc to prepare PR

Signed-off-by: Chen Dai <[email protected]>

Signed-off-by: Chen Dai <[email protected]>
(cherry picked from commit c494d92)
@dai-chen dai-chen deleted the add-table-write-builder branch December 16, 2022 18:42
@dai-chen dai-chen restored the add-table-write-builder branch December 16, 2022 18:42
GabeFernandez310 pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Dec 19, 2022
* Add table write operator and builder

Signed-off-by: Chen Dai <[email protected]>

* Add UT for all new classes

Signed-off-by: Chen Dai <[email protected]>

* Rename child field

Signed-off-by: Chen Dai <[email protected]>

* Add columns field

Signed-off-by: Chen Dai <[email protected]>

* Update javadoc to prepare PR

Signed-off-by: Chen Dai <[email protected]>

Signed-off-by: Chen Dai <[email protected]>
dai-chen added a commit that referenced this pull request Dec 22, 2022
* Add table write operator and builder

Signed-off-by: Chen Dai <[email protected]>

* Add UT for all new classes

Signed-off-by: Chen Dai <[email protected]>

* Rename child field

Signed-off-by: Chen Dai <[email protected]>

* Add columns field

Signed-off-by: Chen Dai <[email protected]>

* Update javadoc to prepare PR

Signed-off-by: Chen Dai <[email protected]>

Signed-off-by: Chen Dai <[email protected]>
(cherry picked from commit c494d92)

Co-authored-by: Chen Dai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport main enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants