Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar in log warnings. #2928

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Aug 9, 2024

Description

I am running into this circuit breaker in opensearch-project/opensearch-api-specification#468 and the logs contain some difficult to understand text.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Swiddis Swiddis merged commit 0e3e57c into opensearch-project:main Oct 21, 2024
13 of 14 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 21, 2024
Signed-off-by: dblock <[email protected]>
(cherry picked from commit 0e3e57c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho pushed a commit that referenced this pull request Oct 21, 2024
(cherry picked from commit 0e3e57c)

Signed-off-by: dblock <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dblock dblock deleted the fix-logs branch October 28, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants