Remove scheduler index from SystemIndexDescriptor #3092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Chu <[email protected]>
noCharger
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224 and
LantaoJin
as code owners
ykmr1224
reviewed
Oct 21, 2024
| @@ -342,9 +342,6 @@ public Collection<SystemIndexDescriptor> getSystemIndexDescriptors(Settings sett | |||
| systemIndexDescriptors.add( | |||
| new SystemIndexDescriptor( | |||
| SPARK_REQUEST_BUFFER_INDEX_NAME + "*", "SQL Spark Request Buffer index pattern")); | |||
| systemIndexDescriptors.add( | |||
| new SystemIndexDescriptor( | |||
| OpenSearchAsyncQueryScheduler.SCHEDULER_INDEX_NAME, "SQL Scheduler job index")); | |||
There was a problem hiding this comment.
Should we remove the constant (SCHEDULER_INDEX_NAME) as well?
There was a problem hiding this comment.
ykmr1224
approved these changes
Oct 22, 2024
derek-ho
requested changes
Oct 22, 2024
There was a problem hiding this comment.
@noCharger can you help me understand why we are now not registering this as system index, would this be backported to 2.x line?
@derek-ho This index will be accessed from managed flint, which has a different auth model. |
seankao-az
approved these changes
Oct 22, 2024
derek-ho
approved these changes
Oct 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
(cherry picked from commit 366d165) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
(cherry picked from commit 366d165) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove scheduler index from SystemIndexDescriptor
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.