Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build stage for service-catalog user-broker binary #645

Closed
wants to merge 1 commit into from
Closed

Add build stage for service-catalog user-broker binary #645

wants to merge 1 commit into from

Conversation

pmorie
Copy link

@pmorie pmorie commented Sep 15, 2017 •
edited
Loading

Part of openshift/origin#16220 - adds a stage to the extended_conformance_install_update job that builds the service catalog test broker binary

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 15, 2017
@pmorie pmorie changed the title Add build stage for service-catalog user-broker-binary Add build stage for service-catalog user-broker binary Sep 15, 2017
jboyd01
jboyd01 approved these changes Sep 15, 2017
View reviewed changes
Copy link
Contributor

@jboyd01 jboyd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmorie
Copy link
Author

pmorie commented Sep 15, 2017 via email

jpeeler
jpeeler reviewed Sep 15, 2017
View reviewed changes
sjb/config/test_cases/test_branch_origin_extended_conformance_install_update.yml
repository: "origin"
timeout: 1800
script: |-
REGISTRY=openshift/ NO_DOCKER=1 make -C cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog user-broker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something to be mindful of (maybe it doesn't matter?) is that this is using the upstream build process rather than the origin tooling (build-go.sh).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we talked about this last night -- this doesn't need to be versioned etc so should be ok

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2018
@openshift-bot
Copy link
Contributor

@pmorie: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jpeeler
Copy link
Contributor

jpeeler commented Feb 14, 2018

I think this can be closed - it's built here: https://github.com/openshift/aos-cd-jobs/blob/99684c80ea476b15581ce315ac044eec11c0d872/sjb/config/test_cases/test_branch_origin_service_catalog.yml#L25

And here: https://github.com/openshift/aos-cd-jobs/blob/99684c80ea476b15581ce315ac044eec11c0d872/sjb/config/test_cases/test_pull_request_origin_service_catalog.yml#L41

@stevekuznetsov
Copy link
Contributor

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeeler jpeeler jpeeler left review comments

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@jboyd01 jboyd01 jboyd01 approved these changes

Assignees

@stevekuznetsov stevekuznetsov

Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pmorie @openshift-bot @jpeeler @stevekuznetsov @jboyd01 @openshift-ci-robot