Fix possible nil pointer dereference in event-dispatcher (#626)

openshift-knative · Jun 12, 2024 · 3894539 · 3894539
1 parent 471dd0a
commit 3894539
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/kncloudevents/event_dispatcher.go b/pkg/kncloudevents/event_dispatcher.go
@@ -303,7 +303,7 @@ func (d *Dispatcher) executeRequest(ctx context.Context, target duckv1.Addressab
 	if isFailure(response.StatusCode) {
 		// Read response body into dispatchInfo for failures
 		if readErr != nil && readErr != io.EOF {
-			dispatchInfo.ResponseBody = []byte(fmt.Sprintf("dispatch resulted in status \"%s\". Could not read response body: error: %s", response.Status, err.Error()))
+			dispatchInfo.ResponseBody = []byte(fmt.Sprintf("dispatch resulted in status \"%s\". Could not read response body: error: %s", response.Status, readErr.Error()))
 		} else {
 			dispatchInfo.ResponseBody = body.Bytes()
 		}
@@ -315,7 +315,7 @@ func (d *Dispatcher) executeRequest(ctx context.Context, target duckv1.Addressab
 
 	var responseMessageBody []byte
 	if readErr != nil && readErr != io.EOF {
-		responseMessageBody = []byte(fmt.Sprintf("Failed to read response body: %s", err.Error()))
+		responseMessageBody = []byte(fmt.Sprintf("Failed to read response body: %s", readErr.Error()))
 	} else {
 		responseMessageBody = body.Bytes()
 		dispatchInfo.ResponseBody = responseMessageBody