-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v1.11] Backport kncloudevents package improvements #492
[release-v1.11] Backport kncloudevents package improvements #492
Conversation
## Proposed Changes Removed the legacy http client go, message sender go and respective test files, Since the functionality are handled in http client new and message sender new go Issue related : knative#6995 - 🗑️ Remove feature or internal logic - - - ### Pre-review Checklist - [x] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec **Release Note** ```release-note ``` **Docs** 📖 knative#6995 --------- Co-authored-by: Christoph Stäbler <[email protected]>
Adds a function (`SendEvent`) to the kncloudevents package to Send events. This function: * configures the client (e.g. for TLS) * has option to send replies * has option to send to a DLS * has option to add additional transformers This allows e.g. for use cases like the following: ``` kncloudevents.SendEvent(ctx, event, sub.Subscriber, kncloudevents.WithHeader(additionalHeaders), kncloudevents.WithReply(sub.Reply), kncloudevents.WithDeadLetterSink(sub.DeadLetter), kncloudevents.WithRetryConfig(sub.RetryConfig)) ``` The `SendMessage` function is provided to make integration with existing packages easier (e.g. in dependent projects). Also migrated the usages of kncloudevents.NewCloudEventRequest() to the new SendEvent() function (mt-broker-filter and mt-broker-ingress): * 74c1552 * 9728713 * 958722d
* Remove kncloudevents.CloudEventsRequest * Run hack/update-codegen.sh * Add unit tests for generateBackoffFn()
Fix dispatcher data race Signed-off-by: Pierangelo Di Pilato <[email protected]>
/assign @creydr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-v1.12 |
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2d2c4d5
into
openshift-knative:release-v1.11
@pierDipi: #492 failed to apply on top of branch "release-v1.12":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This will allow an easier backport for the trust-manager integration, see individual commits and references for details.