Skip to content

Commit

Permalink
[release-v1.10] Sync upstream release (#52)
Browse files Browse the repository at this point in the history
* drop safe-to-evict annotations (knative-extensions#1119)

Co-authored-by: dprotaso <[email protected]>

* Disable update test (knative-extensions#1121)

See: knative-extensions#938

Co-authored-by: dprotaso <[email protected]>

* Sync upstream release

---------

Co-authored-by: Knative Prow Robot <[email protected]>
Co-authored-by: dprotaso <[email protected]>
Co-authored-by: John Doe <johndoe@localhost>
Co-authored-by: nak3 <[email protected]>
  • Loading branch information
5 people authored Jun 9, 2023
1 parent a40ff4f commit 12aabd8
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 8 deletions.
1 change: 0 additions & 1 deletion config/500-controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ spec:
template:
metadata:
annotations:
cluster-autoscaler.kubernetes.io/safe-to-evict: "true"
# This must be outside of the mesh to probe the gateways.
# NOTE: this is allowed here and not elsewhere because
# this is the Istio controller, and so it may be Istio-aware.
Expand Down
2 changes: 0 additions & 2 deletions config/500-webhook-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ spec:
role: net-istio-webhook
template:
metadata:
annotations:
cluster-autoscaler.kubernetes.io/safe-to-evict: "false"
labels:
app: net-istio-webhook
role: net-istio-webhook
Expand Down
3 changes: 0 additions & 3 deletions openshift/release/artifacts/1-net-istio.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ spec:
template:
metadata:
annotations:
cluster-autoscaler.kubernetes.io/safe-to-evict: "true"
# This must be outside of the mesh to probe the gateways.
# NOTE: this is allowed here and not elsewhere because
# this is the Istio controller, and so it may be Istio-aware.
Expand Down Expand Up @@ -238,8 +237,6 @@ spec:
role: net-istio-webhook
template:
metadata:
annotations:
cluster-autoscaler.kubernetes.io/safe-to-evict: "false"
labels:
app: net-istio-webhook
role: net-istio-webhook
Expand Down
14 changes: 12 additions & 2 deletions test/e2e-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,19 @@ initialize $@ --skip-istio-addon

# TODO Re-enable conformance tests for mesh when everything's been fixed
# https://github.com/knative-sandbox/net-istio/issues/584
#
# Also update tests are super flakey and need to be fixed
# https://github.com/knative-sandbox/net-istio/issues/938
#
if [[ $MESH -eq 0 ]]; then
go_test_e2e -timeout=60m ./test/conformance --parallel 12 \
--enable-beta --enable-alpha || fail_test
go_test_e2e \
-timeout 60m \
-parallel 12 \
./test/conformance \
-args \
-enable-alpha \
-enable-beta \
-skip-tests update || fail_test
fi

go_test_e2e -timeout=10m \
Expand Down

0 comments on commit 12aabd8

Please sign in to comment.