Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accel: add ocp upgrade test #116

Merged
merged 1 commit into from
Jul 30, 2024
Merged

accel: add ocp upgrade test #116

merged 1 commit into from
Jul 30, 2024

Conversation

siserafin
Copy link
Collaborator

Adding ocp upgrade test

kononovn
kononovn reviewed Jul 24, 2024
View reviewed changes
.golangci.yml Outdated Show resolved Hide resolved
kononovn
kononovn requested changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check few comment above.

kononovn
kononovn reviewed Jul 25, 2024
View reviewed changes
.golangci.yml Outdated Show resolved Hide resolved
kononovn
kononovn requested changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check few comments above.

@siserafin siserafin force-pushed the upgrade-main-accel-upgrade branch 2 times, most recently from d1793b5 to 5919b6e Compare July 26, 2024 15:13
kononovn
kononovn approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

tests/accel/internal/accelconfig/config.go Outdated
)

const (
// PathToDefaultAccelParamsFile path to config file with default system tests parameters.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with default accel parameters*

cdvultur
cdvultur approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@cdvultur cdvultur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@siserafin siserafin merged commit 60d6678 into openshift-kni:main Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdvultur cdvultur cdvultur approved these changes

@kononovn kononovn kononovn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siserafin @kononovn @cdvultur