Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnf ran: ztp reporting and improvements #119

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

klaskosk
Copy link
Collaborator

  1. Reporting for the custom resources has been added to the ZTP test suite. The caveat is that until eco-goinfra support is added it will be missing the Argo CD Applications CR.
  2. Image registry tests have been changed a bit to test for the path in git before failing if /var/imageregistry is not present.
  3. An additional log has been added to the hub templating tests to provide more information for a failure that ocurred in CI.

1. Reporting for the custom resources has been added to the ZTP test suite. The caveat is that until eco-goinfra support is added it will be missing the Argo CD Applications CR.
2. Image registry tests have been changed a bit to test for the path in git before failing if /var/imageregistry is not present.
3. An additional log has been added to the hub templating tests to provide more information for a failure that ocurred in CI.
Copy link
Collaborator

@yliu127 yliu127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@josclark42 josclark42 self-assigned this Jul 25, 2024
@klaskosk klaskosk merged commit b8f688c into openshift-kni:main Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants