-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system-tests: new test for disk encryption with support for TMPv2 PCR protection #129
Merged
mcornea
merged 6 commits into
openshift-kni:main
from
edcdavid:test-disk-encryption-pcr1
Aug 21, 2024
Merged
system-tests: new test for disk encryption with support for TMPv2 PCR protection #129
mcornea
merged 6 commits into
openshift-kni:main
from
edcdavid:test-disk-encryption-pcr1
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcornea
reviewed
Jul 31, 2024
mcornea
reviewed
Jul 31, 2024
edcdavid
force-pushed
the
test-disk-encryption-pcr1
branch
from
July 31, 2024 15:43
7a60fc2
to
3ed615c
Compare
mcornea
reviewed
Jul 31, 2024
tests/system-tests/diskencryption/internal/parsehelper/parsehelper.go
Outdated
Show resolved
Hide resolved
edcdavid
changed the title
Adding test suite for disk encryption with support for TMPv2 PCR protection
system-tests: new test for disk encryption with support for TMPv2 PCR protection
Jul 31, 2024
edcdavid
force-pushed
the
test-disk-encryption-pcr1
branch
from
August 5, 2024 13:06
3ed615c
to
fd0a3df
Compare
edcdavid
force-pushed
the
test-disk-encryption-pcr1
branch
from
August 5, 2024 15:52
fd0a3df
to
9688a1e
Compare
lgtm |
edcdavid
force-pushed
the
test-disk-encryption-pcr1
branch
6 times, most recently
from
August 15, 2024 14:00
3211fad
to
9f1116c
Compare
edcdavid
force-pushed
the
test-disk-encryption-pcr1
branch
from
August 19, 2024 12:55
9f1116c
to
f00d88c
Compare
lgtm |
klaskosk
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
mcornea
approved these changes
Aug 21, 2024
kononovn
reviewed
Aug 21, 2024
… protection Includes 3 tests: - PCR 1 protection - PCR 7 protection - Disabling PCR protection
…ction during tests
edcdavid
force-pushed
the
test-disk-encryption-pcr1
branch
from
August 21, 2024 13:58
f00d88c
to
5acb3b5
Compare
edcdavid
force-pushed
the
test-disk-encryption-pcr1
branch
from
August 21, 2024 14:01
5acb3b5
to
3699faf
Compare
kononovn
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
global level lgmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review:
Missing additional test case for to test PCR1 protectionThis PR adds a CI test for TPM encryptions with PCR 1 and 7
The test defines the following 3 tests:
Notes: