global: fail fast on retry errors #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edcdavid
approved these changes
Aug 14, 2024
trewest
reviewed
Aug 20, 2024
trewest
reviewed
Aug 20, 2024
As originally used by the cnf/ran directory, retry is only supposed to retry on errors that come from the command execution failing, often from the MCO daemon restarting mid-execution. The current implementation will ignore errors completely that are not to be retried. This masks any errors in the actual command failing. This PR just changes back to the original behavior and will fail fast when the command gets executed but fails, for example, by having a nonzero exit code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As originally used by the cnf/ran directory, retry is only supposed to retry on errors that come from the command execution failing, often from the MCO daemon restarting mid-execution. The current implementation will ignore errors completely that are not to be retried. This masks any errors in the actual command failing.
This PR just changes back to the original behavior and will fail fast when the command gets executed but fails, for example, by having a nonzero exit code.