cnf network: sriov metrics exporter test cases #183
Conversation
ajaggapa
force-pushed
the
metricsfeature
branch
2 times, most recently
from
c7c57ed
to
5a37445
Compare
ajaggapa
force-pushed
the
metricsfeature
branch
2 times, most recently
from
dd1dc08
to
693760e
Compare
ajaggapa
changed the title
ajaggapa
force-pushed
the
metricsfeature
branch
3 times, most recently
from
9e83ac3
to
caf9da1
Compare
ajaggapa
force-pushed
the
metricsfeature
branch
from
caf9da1
to
7d2ce26
Compare
| }) | ||
|
|
||
| Context("Sriov Metrics Exporter - Netdevice to Netdevice", func() { | ||
| It("Sriov Metrics Exporter - Netdevice to Netdevice - Same PF", reportxml.ID("74762"), func() { |
There was a problem hiding this comment.
change the test names to:
Same PF
Different PF
Different Worker
Otherwrise the full name will be:
SriovMetricsExporter Sriov Metrics Exporter - Netdevice to Netdevice Sriov Metrics Exporter - Netdevice to Netdevice - Same PF
| }) | ||
| }) | ||
|
|
||
| Context("Sriov Metrics Exporter - Netdevice to Vfiopci", func() { |
| WithResourceRequest("1Gi", "1Gi", 4). | ||
| WithEnvVar("RUN_TYPE", "testcmd"). | ||
| GetContainerCfg() | ||
| Expect(err).ToNot(HaveOccurred()) |
There was a problem hiding this comment.
Please a failure comment
| NetConfig.PrometheusOperatorNamespace, metav1.ListOptions{LabelSelector: "prometheus=k8s"}) | ||
| Expect(err).ToNot(HaveOccurred(), "Failed to get prometheus pods") | ||
|
|
||
| glog.V(90).Infof(fmt.Sprintf("Running PromQL query: %s", query)) |
There was a problem hiding this comment.
The same, please replace glog by By
ajaggapa
force-pushed
the
metricsfeature
branch
from
7d2ce26
to
ff533c2
Compare
| } | ||
|
|
||
| func definePod(role, devType, worker string) *pod.Builder { | ||
| var podbuild *pod.Builder |
ajaggapa
force-pushed
the
metricsfeature
branch
2 times, most recently
from
16dfb17
to
d1b3311
Compare
ajaggapa
force-pushed
the
metricsfeature
branch
from
d1b3311
to
b4d8585
Compare
| }) | ||
| }) | ||
|
|
||
| Context("Sriov Metrics Exporter - Netdevice to Vfiopci - ", func() { |
There was a problem hiding this comment.
Do you need a space after - ? Is a space automatically added between Context and It for Polarion?
Same for above.
There was a problem hiding this comment.
I am not sure how it works with Polarion when it merges Context and It descriptions. So added space just in case it goes otherwise.
There was a problem hiding this comment.
I checked on an existing test it adds a space automatically between the context and It you can remove the space
There was a problem hiding this comment.
Yeah, i tested it today. So removed spaces now 👍
| }, | ||
| 90*time.Second, 30*time.Second).Should(BeTrue(), "PromQL output does not contain server pod metrics") | ||
|
|
||
| By("Verify RX and TX packets counters are >0") |
ajaggapa
force-pushed
the
metricsfeature
branch
from
b4d8585
to
2c2f619
Compare
ajaggapa
force-pushed
the
metricsfeature
branch
from
2c2f619
to
bddb870
Compare
|
lgtm |
No description provided.