Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cnf ran: reorganize the gitopsztp helpers #184

Merged
merged 1 commit into from
Sep 3, 2024
Merged

cnf ran: reorganize the gitopsztp helpers #184

merged 1 commit into from
Sep 3, 2024

Conversation

klaskosk
Copy link
Collaborator

  • Reorganizes the gitopsztp helpers to make gitdetails and nodedelete their own modules
  • Moves some functions into the ran/internal/ranhelper module for better reusability. The ranhelper package itself will be updated in the next PR.
  • Removes some code that has been shifted to eco-goinfra
  • Removes the argocd-operator dependency and shifts to the eco-goinfra types. This also allows for dumping the application CRs.

@klaskosk
cnf ran: reorganize the gitopsztp helpers
3b3c9b5 
* Reorganizes the gitopsztp helpers to make gitdetails and nodedelete their own modules
* Moves some functions into the ran/internal/ranhelper module for better reusability. The ranhelper package itself will be updated in the next PR.
* Removes some code that has been shifted to eco-goinfra
* Removes the argocd-operator dependency and shifts to the eco-goinfra types. This also allows for dumping the application CRs.
@klaskosk klaskosk merged commit 00bd148 into openshift-kni:main Sep 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josclark42 josclark42 josclark42 approved these changes

@yliu127 yliu127 yliu127 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klaskosk @yliu127 @josclark42