Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnf ran: add ZTP verify BIOS settings test case #204

Merged
merged 9 commits into from
Sep 20, 2024

Conversation

dgonyier
Copy link
Collaborator

ZTP BIOS test added: Compare requested BIOS settings to current BIOS settings

Copy link
Collaborator

@klaskosk klaskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few style comments. Is there supposed to be an actual configuring of BIOS settings as part of the test though? From what I heard from Yang it seemed like you would have to apply a change to the bios settings then verify the change showed up on the node

tests/cnf/ran/gitopsztp/tests/ztp-bios-day-zero.go Outdated Show resolved Hide resolved
tests/cnf/ran/gitopsztp/tests/ztp-bios-day-zero.go Outdated Show resolved Hide resolved
tests/cnf/ran/gitopsztp/tests/ztp-bios-day-zero.go Outdated Show resolved Hide resolved
tests/cnf/ran/gitopsztp/tests/ztp-bios-day-zero.go Outdated Show resolved Hide resolved
tests/cnf/ran/gitopsztp/tests/ztp-bios-day-zero.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@klaskosk klaskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@josclark42
Copy link
Collaborator

/lgtm

@klaskosk klaskosk merged commit 7c3e1c3 into openshift-kni:main Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants