cnf network: Fix sriovmetrics Tests on Intel NICs #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ajaggapa
commented
Sep 26, 2024
ajaggapa
commented
- Create SriovNodePolicies together
- Clear ARP table on switch before executing each Vfio test case
- Increase wait time @line449 for flaky scenarios
evgenLevin
reviewed
Sep 26, 2024
| Expect(err).ToNot(HaveOccurred(), "Failed to get switch credentials") | ||
|
|
||
| jnpr, err := cmd.NewSession(switchCredentials.SwitchIP, switchCredentials.User, switchCredentials.Password) | ||
| Expect(err).ToNot(HaveOccurred()) |
There was a problem hiding this comment.
Please descriptions to all Expects in this func
ajaggapa
force-pushed
the
fixsriovmetrics
branch
from
1f851c3
to
2394afd
Compare
ajaggapa
force-pushed
the
fixsriovmetrics
branch
from
2394afd
to
e19132d
Compare
|
lgtm |
gkopels
approved these changes
Sep 29, 2024
josclark42
pushed a commit
to josclark42/eco-gotests
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.