cnf network: add-metallb-frr-test-cases #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkopels
changed the title
gkopels
force-pushed
the
add-metallb-frrk8-test-case-2
branch
7 times, most recently
from
22ec307
to
e735dee
Compare
|
did a rough check on what the tests are covering, lgtm from that side. I didn't go deeply in what the code does / how it's written |
gkopels
force-pushed
the
add-metallb-frrk8-test-case-2
branch
4 times, most recently
from
e31b751
to
bad8db4
Compare
evgenLevin
reviewed
Oct 2, 2024
| // Get the routes | ||
| frrNodeState, err := metallb.ListFrrNodeState(APIClient) | ||
| Expect(err).ToNot(HaveOccurred(), "Failed to verify BGP routes") | ||
| fmt.Println("frrNodeState[0].Objects.Status.RunningConfig", |
|
|
||
| By("Create first frrconfiguration that receieves a single route") | ||
| createFrrConfiguration(frrConfigFiltered1, ipv4metalLbIPList[0], | ||
| 64500, []string{externalAdvertisedIPv4Routes[0], externalAdvertisedIPv6Routes[0]}, |
There was a problem hiding this comment.
replaced every found
| "frr-k8s-webhook-server deployment is not ready") | ||
|
|
||
| By("Creating BGP Peers") | ||
| createBGPPeerAndVerifyIfItsReady(ipv4metalLbIPList[0], "", 64500, |
There was a problem hiding this comment.
replaced everywhere found for 64500 and 64501
| 64500, []string{externalAdvertisedIPv4Routes[0], externalAdvertisedIPv6Routes[0]}, | ||
| false, false) | ||
|
|
||
| By("Verify Worker-0 Node state update") |
There was a problem hiding this comment.
please replace worker-0
There was a problem hiding this comment.
replaced with a different name like Node 0 ?
|
|
||
| By("Create second frrconfiguration that receives a single route") | ||
| createFrrConfiguration(frrConfigFiltered2, ipv4metalLbIPList[0], | ||
| 64500, []string{externalAdvertisedIPv4Routes[1], externalAdvertisedIPv6Routes[1]}, |
| By("create a secondary IP address on the worker node 0") | ||
| err = createSecondaryInterfaceOnNode("sec-int-worker0", workerNodeList[0].Definition.Name, | ||
| srIovInterfacesUnderTest[0], frrNodeSecIntIPv4Addresses[0], "2001:100::254", vlanID) | ||
| Expect(err).ToNot(HaveOccurred(), "Fail to create a secondary interface on worker0") |
| By("create a secondary IP address on the worker node 1") | ||
| err = createSecondaryInterfaceOnNode("sec-int-worker1", workerNodeList[1].Definition.Name, | ||
| srIovInterfacesUnderTest[0], frrNodeSecIntIPv4Addresses[1], "2001:100::253", vlanID) | ||
| Expect(err).ToNot(HaveOccurred(), "Fail to create a secondary interface on worker1") |
| []string{fmt.Sprintf("%s/24", hubSecIntIPv4Addresses[1])}, | ||
| []string{fmt.Sprintf("%s/24", hubIPv4ExternalAddresses[1])}) | ||
|
|
||
| By("Creating FRR Hub Worker-0 Pod") |
| workerNodeList[0].Object.Name, createHubConfigMapSecInt.Definition.Name, []string{}, | ||
| hub0BRStaticSecIntIPAnnotation) | ||
|
|
||
| By("Creating FRR Hub Worker-1 Pod") |
| _, err := secondaryInterface.Create() | ||
|
|
||
| if err != nil { | ||
| return fmt.Errorf("fail to create secondary interface: %s.+%d", interfaceName, vlanID) |
There was a problem hiding this comment.
verifye erro with Expect
gkopels
force-pushed
the
add-metallb-frrk8-test-case-2
branch
from
bad8db4
to
6490aec
Compare
ajaggapa
reviewed
Oct 3, 2024
| ContainSubstring(externalAdvertisedIPv4Routes[1]), // Second IP address | ||
| ), "Fail to find all expected received routes") | ||
| verifyReceivedRoutes(frrk8sPods, externalAdvertisedIPv4Routes[1]) | ||
| verifyBlockedRoutes(frrk8sPods, prefixToBlock) |
There was a problem hiding this comment.
Another By() for Verifying blocked routes ?
gkopels
force-pushed
the
add-metallb-frrk8-test-case-2
branch
from
6490aec
to
c82bf5b
Compare
evgenLevin
reviewed
Oct 3, 2024
|
|
||
| By("Adding static routes to the speakers") | ||
| speakerRoutesMap := buildRoutesMapWithSpecificRoutes(frrk8sPods, hubSecIntIPv4Addresses) | ||
| Expect(err).ToNot(HaveOccurred(), "Failed to build speaker route map") |
gkopels
force-pushed
the
add-metallb-frrk8-test-case-2
branch
2 times, most recently
from
e8233e8
to
c339d26
Compare
gkopels
force-pushed
the
add-metallb-frrk8-test-case-2
branch
from
c339d26
to
905384c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last two test cases of frrk8 epic