Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lca: cnf exclude operators and sriov nnp from post validation checks #56

Merged
merged 1 commit into from
Jun 20, 2024
Merged

lca: cnf exclude operators and sriov nnp from post validation checks #56

merged 1 commit into from
Jun 20, 2024

Conversation

mcornea
Copy link
Collaborator

@mcornea mcornea commented Jun 20, 2024 •
edited
Loading

  • exclude operators whose version does not change during upgrade
  • exclude default sriov nnp which is not present in 4.16
  • exclude null characters when validating seed entries in etcd for a cleaner output

@mcornea mcornea requested a review from mpmaruthu June 20, 2024 11:53
@yliu127
Copy link
Collaborator

yliu127 commented Jun 20, 2024

/lgtm

@mpmaruthu
Copy link
Collaborator

Looks good to me.
Peri M

@mcornea mcornea merged commit aeec8e9 into openshift-kni:main Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yliu127 yliu127 yliu127 approved these changes

@mpmaruthu mpmaruthu Awaiting requested review from mpmaruthu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcornea @yliu127 @mpmaruthu