Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update makefile: Add ginkgo-install and add binary gen for necessary targets #199

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Update makefile: Add ginkgo-install and add binary gen for necessary targets #199

merged 1 commit into from
Apr 8, 2024

Conversation

mnecas
Copy link
Collaborator

@mnecas mnecas commented Aug 25, 2023 •
edited
Loading

Update makefile:

  • Add ginkgo-install and goimports-install
  • Add binary gen for necessary targets
  • Add bin dir for all built of required binaries
  • Add absolute path to the bin dir

@mnecas mnecas force-pushed the update_makefile branch 3 times, most recently from 267a8cc to 17f4555 Compare August 25, 2023 13:26
@mnecas
Copy link
Collaborator Author

mnecas commented Aug 28, 2023

@jhernand, could you please check it out?

jhernand
jhernand approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@jhernand jhernand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @mnecas.

@mnecas mnecas merged commit 9a8e01b into openshift-online:main Apr 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhernand jhernand jhernand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mnecas @jhernand