Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCM-11993 | Describe cluster shows WifConfig data #683

Merged
merged 1 commit into from
Oct 22, 2024
Merged

OCM-11993 | Describe cluster shows WifConfig data #683

merged 1 commit into from
Oct 22, 2024

Conversation

renan-campos
Copy link
Collaborator 

[rcampos@rcampos-thinkpadt14sgen2i ocm-cli]$ ./ocm describe cluster <REDACTED>

ID:                     <REDACTED>
External ID:            <REDACTED>
Name:                   <REDACTED>
Domain Prefix:          <REDACTED>
Display Name:           <REDACTED>
State:                  ready 
API URL:                <REDACTED>
API Listening:          internal
Console URL:            <REDACTED>
Cluster History URL:    <REDACTED>
Control Plane:
                        Replicas: 3
Infra:
                        Replicas: 3
Compute:
                        Replicas: 3-6 (Autoscaled)
Product:                osd
Subscription type:      standard
Provider:               gcp
Version:                4.17.1
Region:                 us-east1
Multi-az:               true
CNI Type:               OVNKubernetes
SecureBoot:             true
VPC-Name:               osd-ngfw-test-vpc
Control-Plane-Subnet:   osd-ngfw-test-control-plane
Compute-Subnet:         osd-ngfw-test-worker
Wif-Config-Id:          2eilqulr9g8de0k0e2hspk86g2tn3mpr
CCS:                    true
HCP:                    false
Existing VPC:           true
Channel Group:          candidate
Cluster Admin:          true
Organization:           <REDACTED>
Creator:                <REDACTED>
Email:                  <REDACTED>
AccountNumber:          <REDACTED>
Created:                2024-10-22T13:43:03Z
Expiration:             2024-10-24T01:42:58Z
Shard:                  <REDACTED>

renan-campos
renan-campos commented Oct 22, 2024
View reviewed changes
pkg/cluster/describe.go
@@ -248,7 +248,10 @@ func PrintClusterDescription(connection *sdk.Connection, cluster *cmv1.Cluster)
fmt.Printf("Control-Plane-Subnet: %s\n", cluster.GCPNetwork().ControlPlaneSubnet())
}
if cluster.GCPNetwork().ComputeSubnet() != "" {
fmt.Printf("Compute-Subnet: %s\n", cluster.GCPNetwork().ComputeSubnet())
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was modified to match the spacing of the other lines.

@ckandag ckandag merged commit 862b072 into openshift-online:main Oct 22, 2024
4 checks passed
ckandag added a commit that referenced this pull request Oct 25, 2024
@ckandag
Release v1.0.2
021835c 
-8b70707 Release v0.1.76 (#674)
-2ef1e1d Update Konflux references to 67f0290 (#676)
-c63247f Show all WIF configs in interactive dropdown (#677)
-f1d29bc adding interactive move for WifConfig creation (#675)
-1382a6c Require provider, do not default to AWS, and check for provider-specific flags (#678)
-d0b58b4 Do not default GCP authentication type (#679)
-db35759 improve psc cli UX (#681)
-862b072 OCM-11993 | Describe cluster shows WifConfig data (#683)
-4053505 Add PSC-XPN to cluster  description (#685)
-0c456f8 OCM-10728 | interface improvements (#686)
-1e27ded Add more descriptions to WIF resources (#684)
-cdf6466 update filenames in konflux release  container (#687)
-010573f remove version from shasum (#688)
@ckandag ckandag mentioned this pull request Oct 25, 2024
Merged
renan-campos pushed a commit that referenced this pull request Oct 25, 2024
@ckandag
Release v1.0.2 (#689)
c2a39c6 
-8b70707 Release v0.1.76 (#674)
-2ef1e1d Update Konflux references to 67f0290 (#676)
-c63247f Show all WIF configs in interactive dropdown (#677)
-f1d29bc adding interactive move for WifConfig creation (#675)
-1382a6c Require provider, do not default to AWS, and check for provider-specific flags (#678)
-d0b58b4 Do not default GCP authentication type (#679)
-db35759 improve psc cli UX (#681)
-862b072 OCM-11993 | Describe cluster shows WifConfig data (#683)
-4053505 Add PSC-XPN to cluster  description (#685)
-0c456f8 OCM-10728 | interface improvements (#686)
-1e27ded Add more descriptions to WIF resources (#684)
-cdf6466 update filenames in konflux release  container (#687)
-010573f remove version from shasum (#688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckandag ckandag ckandag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renan-campos @ckandag