Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-1743: vSphere - add host and vm based zonal #1999

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

SPLAT-1743: vSphere - add host and vm based zonal #1999

wants to merge 2 commits into from

Conversation

jcpowermac
Copy link
Contributor

@jcpowermac jcpowermac commented Aug 14, 2024 •
edited
Loading

Changes

  • New feature gate VSphereHostVMGroupZonal
  • Add RegionType and ZoneType fields to VSpherePlatformFailureDomainSpec to specify region and zone failure domain types.
  • Add VSphereFailureDomainAffinity type that contains three fields required for vm-host zonal: VMGroup, HostGroup and VMHostRule.
  • Add VSphereFailureDomainAffinity to VSpherePlatformTopology
  • Create additional unit tests to cover the introduction of vm-host zonal provisioning types.
  • Add VMGroup in a machine(s) workspace.

Additional PRs

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 14, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 14, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 14, 2024

Hello @jcpowermac! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 14, 2024
@jcpowermac
Copy link
Contributor Author

(will re-write the commit message with appropriate details once this PR is closer to being ready)

/test build
/test e2e-aws-ovn

/test e2e-aws-ovn-techpreview

/test e2e-upgrade
/test e2e-upgrade-minor
/test images
/test integration
/test unit
/test verify
/test verify-client-go
/test verify-crd-schema
/test verify-deps

@jcpowermac jcpowermac force-pushed the vsphere-add-hostvm-group-zonal branch from 3ea73d9 to b03796b Compare August 20, 2024 20:39
@jcpowermac
Copy link
Contributor Author

/test build
/test images
/test integration
/test unit
/test verify
/test verify-client-go
/test verify-crd-schema
/test verify-deps

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2024
@jcpowermac jcpowermac force-pushed the vsphere-add-hostvm-group-zonal branch 2 times, most recently from f1bb716 to 4790ee0 Compare August 26, 2024 21:02
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2024
@jcpowermac
Copy link
Contributor Author

/test build
/test images
/test integration
/test unit
/test verify
/test verify-client-go
/test verify-crd-schema
/test verify-deps

1 similar comment
@jcpowermac
Copy link
Contributor Author

/test build
/test images
/test integration
/test unit
/test verify
/test verify-client-go
/test verify-crd-schema
/test verify-deps

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2024
@jcpowermac jcpowermac force-pushed the vsphere-add-hostvm-group-zonal branch from dff5476 to e1b6bd3 Compare August 28, 2024 19:04
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2024
@jcpowermac jcpowermac force-pushed the vsphere-add-hostvm-group-zonal branch 2 times, most recently from 2975083 to 3f02f0e Compare September 16, 2024 18:04
@jcpowermac
Copy link
Contributor Author

/test build
/test images
/test integration
/test unit
/test verify
/test verify-client-go
/test verify-crd-schema
/test verify-deps

@jcpowermac
Copy link
Contributor Author

/test build
/test images
/test integration
/test unit
/test verify
/test verify-client-go
/test verify-crd-schema
/test verify-deps

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Changes

Additional PRs

#1999
openshift/installer#8873
openshift/client-go#294
openshift/library-go#1782
openshift/cluster-control-plane-machine-set-operator#325
openshift/machine-api-operator#1285

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Changes

Additional PRs

openshift/enhancements#1677
#1999
openshift/installer#8873
openshift/client-go#294
openshift/library-go#1782
openshift/cluster-control-plane-machine-set-operator#325
openshift/machine-api-operator#1285

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Changes

  • New feature gate VSphereHostVMGroupZonal
  • Add RegionType and ZoneType fields to VSpherePlatformFailureDomainSpec to specify region and zone failure domain types.
  • Add VSphereFailureDomainAffinity type that contains three fields required for vm-host zonal: VMGroup, HostGroup and VMHostRule.
  • Add VSphereFailureDomainAffinity to VSpherePlatformTopology
  • Create additional unit tests to cover the introduction of vm-host zonal provisioning types.

Additional PRs

openshift/enhancements#1677
#1999
openshift/installer#8873
openshift/client-go#294
openshift/library-go#1782
openshift/cluster-control-plane-machine-set-operator#325
openshift/machine-api-operator#1285

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Contributor Author

/test unit

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Changes

  • New feature gate VSphereHostVMGroupZonal
  • Add RegionType and ZoneType fields to VSpherePlatformFailureDomainSpec to specify region and zone failure domain types.
  • Add VSphereFailureDomainAffinity type that contains three fields required for vm-host zonal: VMGroup, HostGroup and VMHostRule.
  • Add VSphereFailureDomainAffinity to VSpherePlatformTopology
  • Create additional unit tests to cover the introduction of vm-host zonal provisioning types.

Additional PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Changes

  • New feature gate VSphereHostVMGroupZonal
  • Add RegionType and ZoneType fields to VSpherePlatformFailureDomainSpec to specify region and zone failure domain types.
  • Add VSphereFailureDomainAffinity type that contains three fields required for vm-host zonal: VMGroup, HostGroup and VMHostRule.
  • Add VSphereFailureDomainAffinity to VSpherePlatformTopology
  • Create additional unit tests to cover the introduction of vm-host zonal provisioning types.
  • Add VMGroup in a machine(s) workspace.

Additional PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jcpowermac
jcpowermac commented Sep 23, 2024
View reviewed changes
tests/generator.go Outdated
@@ -178,6 +179,8 @@ func generateOnCreateTable(onCreateTests []OnCreateTestSpec) {
expectedObj.SetName(gotObj.GetName())
expectedObj.SetNamespace(gotObj.GetNamespace())

fmt.Println(gotObj)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will reset after review

jcpowermac
jcpowermac commented Sep 23, 2024
View reviewed changes
tests/suite_test.go Outdated
@@ -37,7 +37,8 @@ func TestAPIs(t *testing.T) {

var err error
// this assumes a directory. Because it does, we shall assume a path to the serialized featuregate manifests too.
suites, err = LoadTestSuiteSpecs(filepath.Join(".."))
//suites, err = LoadTestSuiteSpecs(filepath.Join(".."))
suites, err = LoadTestSuiteSpecs(filepath.Join("../config/v1/tests/infrastructures.config.openshift.io"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will reset after review

@jcpowermac jcpowermac mentioned this pull request Sep 23, 2024
Open
@rvanderp3
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

New changes are detected. LGTM label has been removed.

@jcpowermac jcpowermac marked this pull request as ready for review September 23, 2024 19:40
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
@openshift-ci openshift-ci bot requested a review from deads2k September 23, 2024 19:41
@openshift-ci openshift-ci bot requested a review from jkyros September 23, 2024 19:41
@jcpowermac
Copy link
Contributor Author

/assign @JoelSpeed

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcpowermac, rvanderp3
Once this PR has been reviewed and has the lgtm label, please ask for approval from joelspeed. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcpowermac
vSphere - add host and vm based zonal
7e48bd6 
New feature gate VSphereHostVMGroupZonal
Add RegionType and ZoneType fields to VSpherePlatformFailureDomainSpec to specify region and zone failure domain types.
Add VSphereFailureDomainAffinity type that contains three fields required for vm-host zonal: VMGroup, HostGroup and VMHostRule.
Add VSphereFailureDomainAffinity to VSpherePlatformTopology
Create additional unit tests to cover the introduction of vm-host zonal provisioning types.
Add VMGroup in a machine(s) workspace.
@jcpowermac
make gen
8cb746e
@jcpowermac jcpowermac force-pushed the vsphere-add-hostvm-group-zonal branch from 7642ae7 to 8cb746e Compare October 2, 2024 13:12
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade-minor 3ea73d9 link true /test e2e-upgrade-minor
ci/prow/verify-crd-schema 8cb746e link true /test verify-crd-schema
ci/prow/verify 8cb746e link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@jkyros jkyros Awaiting requested review from jkyros

Assignees

@JoelSpeed JoelSpeed

@rvanderp3 rvanderp3

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jcpowermac @openshift-ci-robot @rvanderp3 @JoelSpeed @openshift-merge-robot