OCPNODE-2333: add imagepolicy to payload crds #2036
Conversation
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@QiWang19: This pull request references OCPNODE-2333 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
Hello @QiWang19! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/XXL
|
@QiWang19: This pull request references OCPNODE-2333 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test all |
|
/test e2e-aws-ovn-hypershift |
QiWang19
force-pushed
the
imagepolicy-api
branch
from
f1a1737
to
ae31de7
Compare
|
/test all |
|
/retest-required |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
If the CRDs are not presently being added to payload in the MCO repo, then this can merge first, but I notice your PR is also including these in the install dir for MCO, so, it looks like they possibly need to be removed from the install dir so that they aren't introduced into payload twice? |
|
I agree with Joel that the MCO pull should drop its copies of these CRDs. And with that change, I don't see a reason why we can't lift the hold here and land these now. Although I guess you don't want too much space in between this landing and the MCO pull landing, to avoid too many rounds of clusters that have the CRDs in place (via |
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: Qi Wang <[email protected]>
QiWang19
force-pushed
the
imagepolicy-api
branch
from
ae31de7
to
8444a76
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
The manifests were dropped from MCO PR openshift/machine-config-operator#4587 |
|
@JoelSpeed @wking @mtrmac PTAL. |
|
@QiWang19: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Looks good to me. e2e-aws-serial-techpreview failing on cluster-bootstrap is slightly concerning, but poking around there, I'm not seeing a clear signal for what's going wrong, and e2e-aws-ovn-techpreview passed, so seems unlikely that it's "this change breaks TechPreview!" or anything like that.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: QiWang19, wking The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cooperate PR for openshift/machine-config-operator#4587