Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-2010: Rebase to upstream v1.30.5 for OCP 4.18 #77

Merged
merged 49 commits into from
Oct 14, 2024

Conversation

andyzhangx and others added 30 commits July 8, 2024 08:48
…ot/cherry-pick-1961-to-release-1.30

[release-1.30] test: fix trivy action failure
…ot/cherry-pick-1960-to-release-1.30

[release-1.30] fix: incorrect status.creationTime value in snapshot creation with useDataPlaneAPI: “true”
…ot/cherry-pick-1969-to-release-1.30

[release-1.30] feat: add tagValueDelimiter parameter
…ot/cherry-pick-1972-to-release-1.30

[release-1.30] feat: add allowSharedKeyAccess parameter
…ot/cherry-pick-1977-to-release-1.30

[release-1.30] cleanup: logs refine
…n-refresh-1.30

[release-1.30] chore: upgrade azure cloud provider lib
…ot/cherry-pick-1981-to-release-1.30

[release-1.30] cleanup: refine logs
…ot/cherry-pick-1989-to-release-1.30

[release-1.30] feat: add metadata tag on the storage account created by the driver
…atch-permission-1.30

[release-1.30] fix: add pv patch permission with HonorPVReclaimPolicy enabled
…et-update-1.30

[release-1.30] fix: create private endpoint failure when vnetResourceGroup is specified
…azcopy-10.26.0-1.30

[release-1.30] feat: upgrade to azcopy v10.26.0 for volume clone and snapshot restore
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 3, 2024

@dfajmon: This pull request references STOR-2010 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Issue link:
https://issues.redhat.com/browse/STOR-2010

Diff to upstream v1.30.5:
kubernetes-sigs/azurefile-csi-driver@v1.30.5...dfajmon:rebase-1.30.5

Changes between 1.30.3 (OCP 4.17) and 1.30.5 (OCP 4.18):

Full changelogs:
https://github.com/kubernetes-sigs/azurefile-csi-driver/releases/tag/v1.30.5
https://github.com/kubernetes-sigs/azurefile-csi-driver/releases/tag/v1.30.4

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfajmon dfajmon force-pushed the rebase-1.30.5 branch 2 times, most recently from c891b3a to ea55a77 Compare September 3, 2024 08:22
@jsafrane
Copy link

jsafrane commented Sep 3, 2024

/retest
"You have reached or exceeded the maximum number of record resources in zone"

@jsafrane
Copy link

jsafrane commented Sep 4, 2024

/retest

1 similar comment
@dfajmon
Copy link
Author

dfajmon commented Sep 4, 2024

/retest

@jsafrane
Copy link

/lgtm
/approve
/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Sep 16, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
Copy link

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@dfajmon
Copy link
Author

dfajmon commented Oct 7, 2024

@ropatil010 can you check the status on this one please?

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
@RomanBednar
Copy link

RomanBednar commented Oct 11, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
Copy link

openshift-ci bot commented Oct 11, 2024

@dfajmon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ropatil010
Copy link

Adding label based on the test results.

Profile: ipi-on-azure/versioned-installer-ci
Platform: Azure
Payload: 4.18.0-0.test-2024-09-26-145156-ci-ln-zzim4x2-latest

Azure disk driver version:
oc logs pod/azure-disk-csi-driver-controller-7c578d575-6rdmk -c csi-driver
{"name":"disk.csi.azure.com","vendor_version":"v1.30.4"}
Azure file driver version:
oc logs pod/azure-file-csi-driver-controller-85b549c788-jswp2 -c csi-driver
{"name":"file.csi.azure.com","vendor_version":"v1.30.5"}
Az copy version:
oc exec -it pod/azure-file-csi-driver-controller-85b549c788-jswp2 -n openshift-cluster-csi-drivers -c csi-driver /bin/bash
bash-5.1$ /bin/./azcopy --version
azcopy version 10.26.0
For Azure File driver:
quay.io/rhn_support_ropatil/azfile@sha256:1c7f0be9da9823f250e4e698899e66b275c6fe79a98545dd363d7c77c63c189f

https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/ocp-common/job/ginkgo-test/271329/console
10-01 19:01:18.049 109 pass, 159 skip (2h50m56s)

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2024

@dfajmon: This pull request references STOR-2010 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Issue link:
https://issues.redhat.com/browse/STOR-2010

Diff to upstream v1.30.5:
kubernetes-sigs/azurefile-csi-driver@v1.30.5...dfajmon:rebase-1.30.5

Changes between 1.30.3 (OCP 4.17) and 1.30.5 (OCP 4.18):

Full changelogs:
https://github.com/kubernetes-sigs/azurefile-csi-driver/releases/tag/v1.30.5
https://github.com/kubernetes-sigs/azurefile-csi-driver/releases/tag/v1.30.4

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 4b34592 into openshift:master Oct 14, 2024
10 checks passed
@dfajmon dfajmon deleted the rebase-1.30.5 branch October 14, 2024 08:12
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: azure-file-csi-driver
This PR has been included in build ose-azure-file-csi-driver-container-v4.18.0-202410140839.p0.g4b34592.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants