Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start trying to use dep #1

Closed
wants to merge 5 commits into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Aug 10, 2017

@sttts I'm trying to use k8s.io/kube-gen, but I'm having trouble getting it to use a different. Can you see if see what I'm doing wrong (just dep ensure)? I'd really like to start using this, but if I can't use the dependency, I will have to hack something together on godeps+magic I think.

# This file is autogenerated, do not edit; changes may be undone by the next 'dep ensure'.


[[projects]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I the only who thinks toml is ugly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

count me in :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hate ALL file formats. roughly equally, and for different reasons! 😜

Gopkg.toml Outdated
[[constraint]]
name = "k8s.io/kube-gen"
branch = "master"
source = "github.com/deads2k/kube-gen"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't you call it fake-kube-gen?

@sttts
Copy link
Contributor

sttts commented Aug 11, 2017

Opened a golang/dep issue: golang/dep#990

@deads2k
Copy link
Contributor Author

deads2k commented Sep 6, 2017

@sttts thanks for getting everything pushed out. I've been working on this a bit at a time and I think I have something worth looking at again.

@sttts @smarterclayton I don't know why dep wants to pull in every bit of every repo (like glide)

@openshift/api-review I reorganized this into github.com/openshift/client-go/<shortGroupName>/{clientset|internalclientset|listers|informer}. I figured I'd put other code under pkg and we'll just ban anyone from making a group named pkg.

@smarterclayton
Copy link
Contributor

I think that's reasonable (anyone creating a pkg group would fail API review on not using acronyms)

Gopkg.toml Outdated
@@ -33,6 +33,13 @@ required = [
name = "k8s.io/code-generator"
branch = "master"

[[constraint]]
name = "k8s.io/apimachinery"
branch = "release-1.7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this file misses all revision constraints for dependencies (which you only have in Gopkg.lock, which is ignored completely by dep when importing your new openshift/client-go into another project). This is even worse for transitive dependencies. There is no way at all to specify them in your Gopkg.toml for 3rdparty consumers (dep will just ignore them as they are no direct imports). This means that users cannot vendor this (without tons of manual overrides) at all. golang/dep#1124

@sttts
Copy link
Contributor

sttts commented Sep 7, 2017

Note that Gopkg.tml misses all revision constraints for dependencies (which you only have in Gopkg.lock, which is ignored completely by dep when importing your new openshift/client-go into another project). This is even worse for transitive dependencies. There is no way at all to specify them in your Gopkg.toml for 3rdparty consumers (dep will just ignore them as they are no direct imports). This means that users cannot vendor this (without tons of manual overrides) at all. golang/dep#1124

@deads2k
Copy link
Contributor Author

deads2k commented Sep 7, 2017

Note that Gopkg.tml misses all revision constraints for dependencies (which you only have in Gopkg.lock, which is ignored completely by dep when importing your new openshift/client-go into another project). This is even worse for transitive dependencies. There is no way at all to specify them in your Gopkg.toml for 3rdparty consumers (dep will just ignore them as they are no direct imports). This means that users cannot vendor this (without tons of manual overrides) at all. golang/dep#1124

Soo..... don't use dep. Well. That's frustrating.

@deads2k deads2k closed this Sep 21, 2017
eparis pushed a commit to eparis/client-go that referenced this pull request Apr 17, 2019
Create basic files and test package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants