-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start trying to use dep #1
Conversation
25467a2
to
12cff9c
Compare
# This file is autogenerated, do not edit; changes may be undone by the next 'dep ensure'. | ||
|
||
|
||
[[projects]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I the only who thinks toml is ugly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
count me in :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i hate ALL file formats. roughly equally, and for different reasons! 😜
Gopkg.toml
Outdated
[[constraint]] | ||
name = "k8s.io/kube-gen" | ||
branch = "master" | ||
source = "github.com/deads2k/kube-gen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't you call it fake-kube-gen?
Opened a golang/dep issue: golang/dep#990 |
12cff9c
to
6780841
Compare
@sttts thanks for getting everything pushed out. I've been working on this a bit at a time and I think I have something worth looking at again. @sttts @smarterclayton I don't know why @openshift/api-review I reorganized this into |
I think that's reasonable (anyone creating a |
Gopkg.toml
Outdated
@@ -33,6 +33,13 @@ required = [ | |||
name = "k8s.io/code-generator" | |||
branch = "master" | |||
|
|||
[[constraint]] | |||
name = "k8s.io/apimachinery" | |||
branch = "release-1.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this file misses all revision constraints for dependencies (which you only have in Gopkg.lock, which is ignored completely by dep when importing your new openshift/client-go into another project). This is even worse for transitive dependencies. There is no way at all to specify them in your Gopkg.toml for 3rdparty consumers (dep will just ignore them as they are no direct imports). This means that users cannot vendor this (without tons of manual overrides) at all. golang/dep#1124
Note that Gopkg.tml misses all revision constraints for dependencies (which you only have in Gopkg.lock, which is ignored completely by dep when importing your new openshift/client-go into another project). This is even worse for transitive dependencies. There is no way at all to specify them in your Gopkg.toml for 3rdparty consumers (dep will just ignore them as they are no direct imports). This means that users cannot vendor this (without tons of manual overrides) at all. golang/dep#1124 |
Soo..... don't use |
Create basic files and test package
@sttts I'm trying to use k8s.io/kube-gen, but I'm having trouble getting it to use a different. Can you see if see what I'm doing wrong (just
dep ensure
)? I'd really like to start using this, but if I can't use the dependency, I will have to hack something together on godeps+magic I think.