Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: AUTH-544: Extend e2e test to leverage new functionality #737

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

liouk
Copy link
Member

@liouk liouk commented Nov 5, 2024

This PR extends the baseline e2e test to use functionality introduced by the following PRs:

Thus, it requires these PRs in order to work.

Extensions:

  • lets CAO consume auth CR OIDC configuration and generate structured auth config
  • adds tests for the outcome of the configuration:
    • KAS arguments
    • configmap contents
  • adds tests for the validity and correctness of the access & ID OIDC tokens

This PR is set as WIP; the goal is eventually to move this from a pre-merge test to origin.

… map

Drop usage of unsupported config overrides and oidc KAS CLI args. Reuse
IdP CA configmap already copied into openshift-config.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 5, 2024

@liouk: This pull request references AUTH-544 which is a valid jira issue.

In response to this:

This PR extends the baseline e2e test to use functionality introduced by the following PRs:

Thus, it requires these PRs in order to work.

Extensions:

  • lets CAO consume auth CR OIDC configuration and generate structured auth config
  • adds tests for the outcome of the configuration:
  • KAS arguments
  • configmap contents
  • adds tests for the validity and correctness of the access & ID OIDC tokens

This PR is set as WIP; the goal is eventually to move this from a pre-merge test to origin.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 5, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2024
@openshift-ci openshift-ci bot requested review from deads2k and ibihim November 5, 2024 15:29
Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liouk
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 11, 2024

@liouk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify d092ff8 link true /test verify
ci/prow/test-operator-integration d092ff8 link false /test test-operator-integration
ci/prow/e2e-operator d092ff8 link true /test e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants