Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'single-node-production-edge' annotations to CVO manifests. #113

Closed

Conversation

osherdp
Copy link

@osherdp osherdp commented Dec 6, 2020

This adds annotations for the single-node-production-edge cluster profile. There's a growing requirement from several customers to enable creation of single-node (not high-available) Openshift clusters.
In stage one (following openshift/enhancements#504) there should be no implication on components logic.
In the next stage, the component's behavior will match a non high-availability profile if the customer is specifically interested in one.
This PR is separate from the 'single-node-developer' work, which will implement a different behavior and is currently on another stage of implementation.

For more info, please refer to the enhancement link and participate in the discussion.

@osherdp
Copy link
Author

osherdp commented Dec 6, 2020

/hold for openshift/api#813

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2020
@jsafrane
Copy link
Contributor

jsafrane commented Dec 7, 2020

@osherdp, do you expect a single node cluster to run in a cloud? On bare metal, cluster-storage-operator does not do anything useful and could be omitted.

@jsafrane
Copy link
Contributor

jsafrane commented Dec 7, 2020

And please sync with @cfergeau and #106

@osherdp
Copy link
Author

osherdp commented Dec 7, 2020

@jsafrane indeed, not relevant on bare-metal
for CI purposes we do need to run SNO on cloud

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2020
This adds annotations for the single-node-production-edge cluster profile. There's a growing requirement from several customers to enable creation of single-node (not high-available) Openshift clusters.
In stage one (following openshift/enhancements#504) there should be no implication on components logic.
In the next stage, the component's behavior will match a non high-availability profile if the customer is specifically interested in one.
This PR is separate from the 'single-node-developer' work, which will implement a different behavior and is currently on another stage of implementation.

For more info, please refer to the enhancement link and participate in the discussion.
@osherdp osherdp force-pushed the enhancement/single-node-annotation branch from 98d652f to 8b58064 Compare December 9, 2020 07:21
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2020
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 10, 2020
@osherdp
Copy link
Author

osherdp commented Dec 10, 2020

/retest

@jsafrane
Copy link
Contributor

for CI purposes we do need to run SNO on cloud

You can run it on a cloud and pretend it's a bare metal cluster, i.e. not to use any cloud-y feature such as persistent storage. Why would you test cloud persistent volumes if the end product won't support them?

@openshift-merge-robot
Copy link
Contributor

@osherdp: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 8b58064 link /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@osherdp
Copy link
Author

osherdp commented Dec 15, 2020

Shifting strategy based on openshift/enhancements#560

@osherdp osherdp closed this Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants