-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'single-node-production-edge' annotations to CVO manifests. #113
add 'single-node-production-edge' annotations to CVO manifests. #113
Conversation
/hold for openshift/api#813 |
@osherdp, do you expect a single node cluster to run in a cloud? On bare metal, cluster-storage-operator does not do anything useful and could be omitted. |
@jsafrane indeed, not relevant on bare-metal |
This adds annotations for the single-node-production-edge cluster profile. There's a growing requirement from several customers to enable creation of single-node (not high-available) Openshift clusters. In stage one (following openshift/enhancements#504) there should be no implication on components logic. In the next stage, the component's behavior will match a non high-availability profile if the customer is specifically interested in one. This PR is separate from the 'single-node-developer' work, which will implement a different behavior and is currently on another stage of implementation. For more info, please refer to the enhancement link and participate in the discussion.
98d652f
to
8b58064
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, osherdp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
You can run it on a cloud and pretend it's a bare metal cluster, i.e. not to use any cloud-y feature such as persistent storage. Why would you test cloud persistent volumes if the end product won't support them? |
@osherdp: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Shifting strategy based on openshift/enhancements#560 |
This adds annotations for the single-node-production-edge cluster profile. There's a growing requirement from several customers to enable creation of single-node (not high-available) Openshift clusters.
In stage one (following openshift/enhancements#504) there should be no implication on components logic.
In the next stage, the component's behavior will match a non high-availability profile if the customer is specifically interested in one.
This PR is separate from the 'single-node-developer' work, which will implement a different behavior and is currently on another stage of implementation.
For more info, please refer to the enhancement link and participate in the discussion.