-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-30438: Bump protobuf dependency #237
OCPBUGS-30438: Bump protobuf dependency #237
Conversation
@MaysaMacedo: This pull request references Jira Issue OCPBUGS-30438, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test e2e-openstack-csi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It looks like we'll need to bump the github.com/golang/protobuf
lib as well due to a regression introduced in google.golang.org/protobuf
v1.33.0. See golang/protobuf#1596.
@@ -103,7 +103,7 @@ require ( | |||
google.golang.org/genproto/googleapis/api v0.0.0-20240125205218-1f4bbc51befe // indirect | |||
google.golang.org/genproto/googleapis/rpc v0.0.0-20240125205218-1f4bbc51befe // indirect | |||
google.golang.org/grpc v1.61.0 // indirect | |||
google.golang.org/protobuf v1.32.0 // indirect | |||
google.golang.org/protobuf v1.33.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you see golang/protobuf#1596?
Looks like we'll also need to bump github.com/golang/protobuf to v1.5.4
. We currently have it to the incompatible v1.5.3
version.
4c32027
to
30d97c6
Compare
/jira refresh |
@MaysaMacedo: This pull request references Jira Issue OCPBUGS-30438, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@MaysaMacedo: This pull request references Jira Issue OCPBUGS-30438, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@MaysaMacedo: This pull request references Jira Issue OCPBUGS-30438, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approve |
/label cherry-pick-approved |
/test e2e-openstack-csi |
/label backport-risk-assessed |
@EmilienM: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@MaysaMacedo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/label backport-risk-assessed
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, mandre, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CI is passing, we can remove the hold. |
bdac0fd
into
openshift:release-4.16
@MaysaMacedo: Jira Issue OCPBUGS-30438: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-30438 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: csi-driver-manila-operator |
Fix included in accepted release 4.16.0-0.nightly-2024-08-28-181245 |
No description provided.