Merge pull request #713 from sgreene570/move-my-eps-to-implemented

Ingress: Post-implementation fixups for a couple of EPs
openshift · Apr 12, 2021 · d5c1c02 · d5c1c02
2 parents e5ac7e1 + 0fe15c7
commit d5c1c02
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/enhancements/ingress/gcp-lb-global-access.md b/enhancements/ingress/gcp-lb-global-access.md
@@ -16,8 +16,8 @@ approvers:
   - "@knobunc"
   - "@miciah"
 creation-date: 2021-02-09
-last-updated: 2021-02-12
-status: implementable
+last-updated: 2021-03-30
+status: implemented
 ---
 
 # GCP Internal Ingress Load Balancer Global Access Option

diff --git a/enhancements/ingress/tunable-router-buffer-sizes.md b/enhancements/ingress/tunable-router-buffer-sizes.md
@@ -16,8 +16,8 @@ approvers:
   - "@frobware"
   - "@danehans"
 creation-date: 2020-08-18
-last-updated: 2021-02-12
-status: implementable
+last-updated: 2021-03-30
+status: implemented
 see-also:
 replaces:
 superseded-by:
@@ -92,20 +92,20 @@ type IngressControllerHttpHeaderBuffer struct {
 	// headerBufferSize describes how much memory should be reserved
 	// (in bytes) for IngressController connection sessions.
 	//
-	// +kubebuilder:validation:required
+	// +kubebuilder:validation:Optional
 	// +kubebuilder:validation:minimum=16384
-	// +required
-	HeaderBufferSize int `json:"headerBufferSize"`
+	// +optional
+	HeaderBufferSize int32 `json:"headerBufferSize,omitempty"`
 
 	// headerBufferMaxRewrite describes how much memory should be reserved
 	// (in bytes) from headerBufferSize for HTTP header rewriting
 	// and appending. Note that incoming HTTP requests will be limited to
 	// (headerBufferSize - headerBufferMaxRewrite) bytes.
 	//
-	// +kubebuilder:validation:required
+	// +kubebuilder:validation:Optional
 	// +kubebuilder:validation:minimum=4096
-	// +required
-	HeaderBufferMaxRewrite int `json:"headerBufferMaxRewrite"`
+	// +optional
+	HeaderBufferMaxRewrite int32 `json:"headerBufferMaxRewrite,omitempty"`
 }
 ```