Add dedicated instances proposal #468

alexander-demicev · 2020-09-03T13:07:37Z

No description provided.

JoelSpeed

This is a good start! I think it would be good to flesh out with more code examples and would be good to understand what is required on the installer side to be able to create the resources required on GCP and Azure, do you think you could expand on this?

If we can, it would be good to include some User stories as well, and to expand on the motivation, goals, non-goals too

enhancements/machine-api/dedicated-instances.md

+}
+```
+
+That change will require adding `Tenancy` field to provider spec.


enhancements/machine-api/dedicated-instances.md

elmiko

most of this makes sense to me, i left some suggestions and a question

enhancements/machine-api/dedicated-instances.md

enxebre · 2020-09-07T09:27:37Z

Thanks for putting this together @alexander-demichev. I think this effort is pretty much about exposing a new field on the AWS providerSpec. Still I think is nice having this info into one single place so I'm good to merge the after addressing comments if you want. Regardless I'm tracking in Jira the work that we need to get done. I.e:

Expose tenancy dedicated field on aws providerSpec.
Include an e2e test which spin up a dedicated instance via machineSet.
Include webhook validation for the new field input.
Estimate and reasonable limit, cost and request to bump aws dedicated limits on our CI acccount.
Include the changes for the upstream aws cluster API actuator.

itamarh · 2020-09-10T14:08:46Z

Any thoughts how this could look like with KubeVirt (on bare metal instances) for creating virt nodes on demand?

enhancements/machine-api/dedicated-instances.md

openshift-bot · 2020-12-22T16:52:55Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

JoelSpeed · 2021-01-04T09:47:02Z

@alexander-demichev Given this feature was implemented and merged, we need to get this tidied up and merged. Can you take a look at the outstanding comments and clean this up please

/remove-lifecycle stale

openshift-ci-robot · 2021-01-06T12:29:03Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dustymabe after the PR has been reviewed.
You can assign the PR to them by writing /assign @dustymabe in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

alexander-demicev · 2021-01-06T12:29:24Z

@JoelSpeed All should be fixed now.

openshift-bot · 2021-04-06T12:31:43Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

JoelSpeed · 2021-04-06T14:01:18Z

@elmiko Could you give this another review?

elmiko

this is mostly making sense to me, and i think it reads pretty well. i have one small suggestion.

elmiko · 2021-04-06T20:47:05Z

enhancements/machine-api/dedicated-instances.md

+
+## Summary
+
+Make it possible for users to create machines which run as dedicated instances. 


i think it would be nice to define what a "dedicated instance" is here. maybe just add a second sentence that starts "A dedicated instance is a ...."

openshift-bot · 2021-05-06T22:35:50Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

JoelSpeed · 2021-05-07T09:15:14Z

/remove-lifecycle rotten

openshift-bot · 2021-08-05T14:37:58Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

elmiko

looks mostly good to me Alex, just a couple questions

elmiko · 2021-08-18T14:27:19Z

enhancements/machine-api/dedicated-instances.md

+
+#### Autoscaling
+
+Autoscaling dedicated instances can be a problem because dedicated hosts have quotas and limits on provider side. We should provide good documentation here.


is there any more detail we could add here, what does the user need to be aware of?

nothing more that I know about

elmiko · 2021-08-18T14:28:24Z

enhancements/machine-api/dedicated-instances.md

+## Design Details
+
+### Open Questions
+
+### Test Plan
+
+### Graduation Criteria
+
+#### Examples
+
+##### Dev Preview -> Tech Preview
+
+##### Tech Preview -> GA 
+
+##### Removing a deprecated feature
+
+### Upgrade / Downgrade Strategy
+
+### Version Skew Strategy
+
+## Implementation History
+
+## Drawbacks
+
+## Alternatives


is there any information to be added for these sections?

elmiko · 2021-08-18T14:29:12Z

/remove-lifecycle stale

elmiko

the info looks good to me, +1

alexander-demicev · 2021-08-19T12:44:54Z

@elmiko I added a link to implementation https://github.com/openshift/enhancements/pull/468/files#diff-d3eb6604aecfb02079e4440173764bd1fb31ac20a2e93ae75dee709854ebb9caR192

JoelSpeed

~~Do we want to make a note that this is implemented for AWS?~~
Never mind I see we have that

JoelSpeed · 2021-08-19T15:11:31Z

enhancements/machine-api/dedicated-instances.md

+  - "@JoelSpeed"
+  - "@enxebre"
+creation-date: 2020-09-01
+last-updated: 2020-09-01


Suggested change

last-updated: 2020-09-01

last-updated: 2021-08-19

JoelSpeed · 2021-08-19T15:16:07Z

/approve

openshift-ci · 2021-08-19T15:18:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

elmiko

thanks Alex
/lgtm

openshift-ci-robot requested review from dustymabe and sudhaponnaganti September 3, 2020 13:07

JoelSpeed reviewed Sep 3, 2020

View reviewed changes

elmiko reviewed Sep 3, 2020

View reviewed changes

alexander-demicev force-pushed the dedicatedinstances branch from 810fd73 to 54c13a3 Compare September 4, 2020 12:07

enxebre reviewed Sep 7, 2020

View reviewed changes

enhancements/machine-api/dedicated-instances.md Outdated Show resolved Hide resolved

enxebre reviewed Sep 7, 2020

View reviewed changes

enhancements/machine-api/dedicated-instances.md Outdated Show resolved Hide resolved

enxebre reviewed Sep 7, 2020

View reviewed changes

enhancements/machine-api/dedicated-instances.md Outdated Show resolved Hide resolved

enxebre reviewed Sep 7, 2020

View reviewed changes

enhancements/machine-api/dedicated-instances.md Outdated Show resolved Hide resolved

enxebre reviewed Sep 7, 2020

View reviewed changes

enhancements/machine-api/dedicated-instances.md Show resolved Hide resolved

alexander-demicev force-pushed the dedicatedinstances branch from 54c13a3 to bb1824f Compare September 7, 2020 16:57

JoelSpeed reviewed Sep 23, 2020

View reviewed changes

openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2020

openshift-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2021

alexander-demicev force-pushed the dedicatedinstances branch from bb1824f to 037e867 Compare January 6, 2021 12:28

alexander-demicev force-pushed the dedicatedinstances branch from 037e867 to bd5e98b Compare January 6, 2021 12:30

openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 6, 2021

elmiko reviewed Apr 6, 2021

View reviewed changes

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 6, 2021

openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 7, 2021

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 5, 2021

alexander-demicev force-pushed the dedicatedinstances branch from bd5e98b to e789d51 Compare August 18, 2021 13:35

elmiko reviewed Aug 18, 2021

View reviewed changes

openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2021

alexander-demicev force-pushed the dedicatedinstances branch from e789d51 to 9da7433 Compare August 18, 2021 15:12

elmiko reviewed Aug 18, 2021

View reviewed changes

alexander-demicev force-pushed the dedicatedinstances branch from 9da7433 to 9f52e8c Compare August 19, 2021 10:08

Add dedicated instances proposal

94ffb06

alexander-demicev force-pushed the dedicatedinstances branch from 9f52e8c to 94ffb06 Compare August 19, 2021 10:15

JoelSpeed reviewed Aug 19, 2021

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021

elmiko reviewed Aug 19, 2021

View reviewed changes

openshift-ci bot assigned elmiko Aug 19, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2021

openshift-merge-robot merged commit e45cb34 into openshift:master Aug 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dedicated instances proposal #468

Add dedicated instances proposal #468

alexander-demicev commented Sep 3, 2020

JoelSpeed left a comment

This comment was marked as resolved.

elmiko left a comment

enxebre commented Sep 7, 2020

itamarh commented Sep 10, 2020

openshift-bot commented Dec 22, 2020

JoelSpeed commented Jan 4, 2021

openshift-ci-robot commented Jan 6, 2021

alexander-demicev commented Jan 6, 2021

openshift-bot commented Apr 6, 2021

JoelSpeed commented Apr 6, 2021

elmiko left a comment

elmiko Apr 6, 2021

openshift-bot commented May 6, 2021

JoelSpeed commented May 7, 2021

openshift-bot commented Aug 5, 2021

elmiko left a comment

elmiko Aug 18, 2021

alexander-demicev Aug 18, 2021

elmiko Aug 18, 2021

elmiko commented Aug 18, 2021

elmiko left a comment

alexander-demicev commented Aug 19, 2021

JoelSpeed left a comment •

edited

Loading

JoelSpeed Aug 19, 2021

JoelSpeed commented Aug 19, 2021

openshift-ci bot commented Aug 19, 2021

elmiko left a comment


		## Summary

		Make it possible for users to create machines which run as dedicated instances.


		#### Autoscaling

		Autoscaling dedicated instances can be a problem because dedicated hosts have quotas and limits on provider side. We should provide good documentation here.

Add dedicated instances proposal #468

Add dedicated instances proposal #468

Conversation

alexander-demicev commented Sep 3, 2020

JoelSpeed left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

elmiko left a comment

Choose a reason for hiding this comment

enxebre commented Sep 7, 2020

itamarh commented Sep 10, 2020

openshift-bot commented Dec 22, 2020

JoelSpeed commented Jan 4, 2021

openshift-ci-robot commented Jan 6, 2021

alexander-demicev commented Jan 6, 2021

openshift-bot commented Apr 6, 2021

JoelSpeed commented Apr 6, 2021

elmiko left a comment

Choose a reason for hiding this comment

elmiko Apr 6, 2021

Choose a reason for hiding this comment

openshift-bot commented May 6, 2021

JoelSpeed commented May 7, 2021

openshift-bot commented Aug 5, 2021

elmiko left a comment

Choose a reason for hiding this comment

elmiko Aug 18, 2021

Choose a reason for hiding this comment

alexander-demicev Aug 18, 2021

Choose a reason for hiding this comment

elmiko Aug 18, 2021

Choose a reason for hiding this comment

elmiko commented Aug 18, 2021

elmiko left a comment

Choose a reason for hiding this comment

alexander-demicev commented Aug 19, 2021

JoelSpeed left a comment • edited Loading

Choose a reason for hiding this comment

JoelSpeed Aug 19, 2021

Choose a reason for hiding this comment

JoelSpeed commented Aug 19, 2021

openshift-ci bot commented Aug 19, 2021

elmiko left a comment

Choose a reason for hiding this comment

JoelSpeed left a comment •

edited

Loading