-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial proposal of "allow-from-router" NetworkPolicy #561
Initial proposal of "allow-from-router" NetworkPolicy #561
Conversation
a6e24d3
to
cf95652
Compare
Overall it makes sense to me. The implementation details for ovn-k need to be figured out in the context of the changes we are making to the topology to avoid multiple SNATs (if that's at all relevant here, I don't think it is, but I may be missing some nuances from the recent discussions). |
I think this make sense, and is ripe for implementation. /lgtm |
/approve Nicely written enhancement, thanks |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: russellb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
cf95652
to
ab605b9
Compare
/lgtm |
For SDN-1340. Proposes changes to ovn-kubernetes and CNO (and maybe openshift-sdn, and maybe maybe cluster-ingress-operator) to make it easier for customers to create policies to allow traffic from routers, regardless of network plugin and router configuration.
/cc @trozet
for ovn-kubernetes thoughts
/cc @Miciah
for router thoughts (feel free to hand off to someone else if I picked badly)
/cc @squeed @knobunc @dcbw
for general thoughts