[SDN-1364] Add Network Policy audit logging Enhancement #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
astoycos
changed the title
astoycos
force-pushed
the
add-np-audit-logging
branch
2 times, most recently
from
f13ec8f
to
cdc7a64
Compare
|
updated the reviewers list to match what's in the enhancement doc |
|
@astoycos note the markdown lint job failure. you can run it locally with |
Billy99
reviewed
Feb 1, 2021
russellb
reviewed
Feb 1, 2021
astoycos
force-pushed
the
add-np-audit-logging
branch
2 times, most recently
from
e98b42b
to
078309a
Compare
There was a problem hiding this comment.
Hi @astoycos , thanks for getting this ready! Overall LGTM, just a few nits!
astoycos
force-pushed
the
add-np-audit-logging
branch
from
078309a
to
b702b49
Compare
russellb
reviewed
Feb 2, 2021
russellb
reviewed
Feb 2, 2021
russellb
reviewed
Feb 2, 2021
russellb
reviewed
Feb 2, 2021
russellb
reviewed
Feb 2, 2021
astoycos
force-pushed
the
add-np-audit-logging
branch
from
b702b49
to
f0e8c35
Compare
Creat an enhancemnt for the feature relating to the Jira Epic [SDN-1364](https://issues.redhat.com/browse/SDN-1364) Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
force-pushed
the
add-np-audit-logging
branch
from
f0e8c35
to
db5e983
Compare
russellb
reviewed
Feb 16, 2021
There was a problem hiding this comment.
We've got some open questions remaining, and they're mostly captured in "open questions".
If you want to change this to "provisional" instead of "implemented", we can probably land it sooner and iterate with further PRs to get it to "implementable" once we have the open questions sorted.
squeed
reviewed
Feb 17, 2021
astoycos
added a commit
to astoycos/api
that referenced
this pull request
Mar 10, 2021
API changes For [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 15, 2021
Changes or [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 15, 2021
Changes or [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 15, 2021
Changes or [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 15, 2021
Changes or [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 15, 2021
Changes or [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 16, 2021
Changes or [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 16, 2021
Changes or [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/api
that referenced
this pull request
Mar 17, 2021
API changes For [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 18, 2021
Changes for [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Changed `ovn-kubernetes.go` to digest new api fields Added new sidecar container to the ovnkube-node daemonset that handles tailing the logs, and log rotation. Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 18, 2021
Changes for [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Changed `ovn-kubernetes.go` to digest new api fields Added new sidecar container to the ovnkube-node daemonset that handles tailing the logs, and log rotation. Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 23, 2021
Changes for [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Changed `ovn-kubernetes.go` to digest new api fields Added new sidecar container to the ovnkube-node daemonset that handles tailing the logs, and log rotation. Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 23, 2021
Changes for [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Changed `ovn-kubernetes.go` to digest new api fields Added new sidecar container to the ovnkube-node daemonset that handles tailing the logs, and log rotation. Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 23, 2021
Changes for [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Changed `ovn-kubernetes.go` to digest new api fields Added new sidecar container to the ovnkube-node daemonset that handles tailing the logs, and log rotation. Signed-off-by: Andrew Stoycos <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knobunc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 25, 2021
Changes for [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Changed `ovn-kubernetes.go` to digest new api fields Added new sidecar container to the ovnkube-node daemonset that handles tailing the logs, and log rotation. add resource limits to the new sidecar container Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 29, 2021
Changes for [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Changed `ovn-kubernetes.go` to digest new api fields Added new sidecar container to the ovnkube-node daemonset that handles tailing the logs, and log rotation. add resource limits to the new sidecar container Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 29, 2021
Changes for [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Changed `ovn-kubernetes.go` to digest new api fields Added new sidecar container to the ovnkube-node daemonset that handles tailing the logs, and log rotation. add resource limits to the new sidecar container Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 29, 2021
Changes for [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Changed `ovn-kubernetes.go` to digest new api fields Added new sidecar container to the ovnkube-node daemonset that handles tailing the logs, and log rotation. add resource limits to the new sidecar container Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 29, 2021
Changes for [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Changed `ovn-kubernetes.go` to digest new api fields Added new sidecar container to the ovnkube-node daemonset that handles tailing the logs, and log rotation. add resource limits to the new sidecar container Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 29, 2021
Changes for [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Changed `ovn-kubernetes.go` to digest new api fields Added new sidecar container to the ovnkube-node daemonset that handles tailing the logs, and log rotation. add resource limits to the new sidecar container Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 29, 2021
Changes for [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Changed `ovn-kubernetes.go` to digest new api fields Added new sidecar container to the ovnkube-node daemonset that handles tailing the logs, and log rotation. add resource limits to the new sidecar container Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Mar 31, 2021
Changes for [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Changed `ovn-kubernetes.go` to digest new api fields Added new sidecar container to the ovnkube-node daemonset that handles tailing the logs, and log rotation. add resource limits to the new sidecar container Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
added a commit
to astoycos/cluster-network-operator
that referenced
this pull request
Apr 1, 2021
Changes for [SDN-1364](https://issues.redhat.com/browse/SDN-1364) See [Enhancement](openshift/enhancements#617) for details on the changes Changed `ovn-kubernetes.go` to digest new api fields Added new sidecar container to the ovnkube-node daemonset that handles tailing the logs, and log rotation. add resource limits to the new sidecar container Signed-off-by: Andrew Stoycos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creat an enhancemnt for the feature relating to
the Jira Epic SDN-1364
Signed-off-by: Andrew Stoycos [email protected]