-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingress: HAProxy thread tuning #708
Ingress: HAProxy thread tuning #708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM but leaving for additional reviews/comments.
BTW, please put "ingress:" in the title of the PR, and add a description to the PR (you can copy and paste the summary from the enhancement proposal). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far! Some very minor suggestions.
84f4822
to
232a3ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks!
/approve
/lgtm
creation-date: 2021-03-24 | ||
last-updated: 2021-03-26 | ||
status: provisional|implementable|implemented|deferred|rejected|withdrawn|replaced|informational | ||
see-also: [Tunalbe Router Buffer Sizes](https://github.com/openshift/enhancements/pull/449) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these references are supposed to be formatted like this:
see-also: [Tunalbe Router Buffer Sizes](https://github.com/openshift/enhancements/pull/449) | |
see-also: | |
- "/enhancements/ingress/tunable-router-buffer-sizes.md" |
Looks like there is little consistency among existing enhancements though. Let's sort this out separately; no need to hold up the PR for this.
- "@danehans" | ||
creation-date: 2021-03-24 | ||
last-updated: 2021-03-26 | ||
status: provisional|implementable|implemented|deferred|rejected|withdrawn|replaced|informational |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status: provisional|implementable|implemented|deferred|rejected|withdrawn|replaced|informational | |
status: implementable |
...But let's get this in a follow-up, when we can change the status to "implemented". * grin *.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This proposal is to allow the cluster administrator to configure the number of connection handling threads within ingress controller pods.