Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress: HAProxy thread tuning #708

Merged
merged 3 commits into from
Mar 29, 2021

Conversation

rfredette
Copy link
Contributor

@rfredette rfredette commented Mar 25, 2021

This proposal is to allow the cluster administrator to configure the number of connection handling threads within ingress controller pods.

Copy link
Contributor

@frobware frobware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM but leaving for additional reviews/comments.

enhancements/ingress/haproxy-thread-tuning.md Outdated Show resolved Hide resolved
enhancements/ingress/haproxy-thread-tuning.md Outdated Show resolved Hide resolved
enhancements/ingress/haproxy-thread-tuning.md Outdated Show resolved Hide resolved
enhancements/ingress/haproxy-thread-tuning.md Show resolved Hide resolved
enhancements/ingress/haproxy-thread-tuning.md Outdated Show resolved Hide resolved
enhancements/ingress/haproxy-thread-tuning.md Outdated Show resolved Hide resolved
enhancements/ingress/haproxy-thread-tuning.md Outdated Show resolved Hide resolved
enhancements/ingress/haproxy-thread-tuning.md Outdated Show resolved Hide resolved
enhancements/ingress/haproxy-thread-tuning.md Outdated Show resolved Hide resolved
@Miciah
Copy link
Contributor

Miciah commented Mar 25, 2021

BTW, please put "ingress:" in the title of the PR, and add a description to the PR (you can copy and paste the summary from the enhancement proposal).

Copy link
Contributor

@sgreene570 sgreene570 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far! Some very minor suggestions.

enhancements/ingress/haproxy-thread-tuning.md Outdated Show resolved Hide resolved
enhancements/ingress/haproxy-thread-tuning.md Outdated Show resolved Hide resolved
@rfredette rfredette changed the title NE-302: HAProxy thread tuning Ingress: HAProxy thread tuning Mar 26, 2021
Copy link
Contributor

@Miciah Miciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!
/approve
/lgtm

creation-date: 2021-03-24
last-updated: 2021-03-26
status: provisional|implementable|implemented|deferred|rejected|withdrawn|replaced|informational
see-also: [Tunalbe Router Buffer Sizes](https://github.com/openshift/enhancements/pull/449)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these references are supposed to be formatted like this:

Suggested change
see-also: [Tunalbe Router Buffer Sizes](https://github.com/openshift/enhancements/pull/449)
see-also:
- "/enhancements/ingress/tunable-router-buffer-sizes.md"

Looks like there is little consistency among existing enhancements though. Let's sort this out separately; no need to hold up the PR for this.

- "@danehans"
creation-date: 2021-03-24
last-updated: 2021-03-26
status: provisional|implementable|implemented|deferred|rejected|withdrawn|replaced|informational
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
status: provisional|implementable|implemented|deferred|rejected|withdrawn|replaced|informational
status: implementable

...But let's get this in a follow-up, when we can change the status to "implemented". * grin *.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2021
@openshift-merge-robot openshift-merge-robot merged commit 9bb838a into openshift:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants