Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingress: Post-implementation fixups for a couple of EPs #713

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Ingress: Post-implementation fixups for a couple of EPs #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions enhancements/ingress/gcp-lb-global-access.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ approvers:
- "@knobunc"
- "@miciah"
creation-date: 2021-02-09
last-updated: 2021-02-12
status: implementable
last-updated: 2021-03-30
status: implemented
---

# GCP Internal Ingress Load Balancer Global Access Option
Expand Down
16 changes: 8 additions & 8 deletions enhancements/ingress/tunable-router-buffer-sizes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ approvers:
- "@frobware"
- "@danehans"
creation-date: 2020-08-18
last-updated: 2021-02-12
status: implementable
last-updated: 2021-03-30
status: implemented
see-also:
replaces:
superseded-by:
Expand Down Expand Up @@ -92,20 +92,20 @@ type IngressControllerHttpHeaderBuffer struct {
// headerBufferSize describes how much memory should be reserved
// (in bytes) for IngressController connection sessions.
//
// +kubebuilder:validation:required
// +kubebuilder:validation:Optional
// +kubebuilder:validation:minimum=16384
// +required
HeaderBufferSize int `json:"headerBufferSize"`
// +optional
HeaderBufferSize int32 `json:"headerBufferSize,omitempty"`

// headerBufferMaxRewrite describes how much memory should be reserved
// (in bytes) from headerBufferSize for HTTP header rewriting
// and appending. Note that incoming HTTP requests will be limited to
// (headerBufferSize - headerBufferMaxRewrite) bytes.
//
// +kubebuilder:validation:required
// +kubebuilder:validation:Optional
// +kubebuilder:validation:minimum=4096
// +required
HeaderBufferMaxRewrite int `json:"headerBufferMaxRewrite"`
// +optional
HeaderBufferMaxRewrite int32 `json:"headerBufferMaxRewrite,omitempty"`
}
```

Expand Down