Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase to upstream v0.12.0 #42

Merged
merged 284 commits into from
Jun 21, 2022
Merged

Conversation

alebedev87 and others added 30 commits December 15, 2021 18:42
Add missing test for AWS geolocation subdivision routing policy
…-eventhandler

Add event handler for OpenShift Route source
…ot/go_modules/github.com/exoscale/egoscale-0.80.1

build(deps): bump github.com/exoscale/egoscale from 0.73.2 to 0.80.1
…ot/go_modules/github.com/gophercloud/gophercloud-0.22.0

build(deps): bump github.com/gophercloud/gophercloud from 0.21.0 to 0.22.0
…loudflare-logging

Cloudflare provider - Removed incorrect log message
Signed-off-by: GitHub <[email protected]>
…rt-proxy-upstream

BlueCat: use proxy env variables
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
…alpine-version

chore(dockerfile): bump alpine version to 3.15
@openshift-ci openshift-ci bot requested review from knobunc and rfredette June 3, 2022 07:44
@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2022

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alebedev87
Copy link
Author

Test of this rebase: openshift/external-dns-operator#163

@@ -0,0 +1,43 @@
name: Release Docs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alebedev87 Have you looked at this new github workflow? It looks like it auto-generates docs and commits them back to the repo. I think it only happens if you create a tag with a version number, so if we don't tag our versions like that it probably won't matter, but it may be adding more commits that will make the next rebase a bit more work.

I think it's probably fine to leave this alone, but if it starts getting triggered, we may want to disable it like we did with dependabot

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I didn't have a look at the github workflow. Yes, indeed it might have been a problem especially if we would make use of tags in this repository. Will have to see whether it'll give us some noise.

@rfredette
Copy link

It looks good to me, but I'm going to add a hold for you to look at my other comment. If you don't think it needs to be changed, feel free to remove the hold.

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2022
@alebedev87
Copy link
Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2022
@alebedev87
Copy link
Author

/label qe-approved
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jun 21, 2022
@openshift-ci openshift-ci bot merged commit 3873fd9 into openshift:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.