-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase to upstream v0.12.0 #42
Conversation
Add missing test for AWS geolocation subdivision routing policy
Document usage of AWS env vars
…-eventhandler Add event handler for OpenShift Route source
Signed-off-by: GitHub <[email protected]>
…ot/go_modules/github.com/exoscale/egoscale-0.80.1 build(deps): bump github.com/exoscale/egoscale from 0.73.2 to 0.80.1
…ot/go_modules/github.com/gophercloud/gophercloud-0.22.0 build(deps): bump github.com/gophercloud/gophercloud from 0.21.0 to 0.22.0
…mp-kustomize bump kustomize to v0.10.2
RFC2136: add NS record support
…flare-go Bump Cloudflare-Go
Signed-off-by: Alexander Berger <[email protected]>
…loudflare-logging Cloudflare provider - Removed incorrect log message
Fix ingress spec in given examples
Signed-off-by: GitHub <[email protected]>
…x-build Fix build by fixing go.sum
…rt-proxy-upstream BlueCat: use proxy env variables
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
…x-trivy-again Fix trivy workflow
Signed-off-by: Cyril Corbon <[email protected]>
…alpine-version chore(dockerfile): bump alpine version to 3.15
…move-broken-link Remove broken link
Signed-off-by: GitHub <[email protected]>
…x-dependabot-yaml Bump yaml.v3 to fix vulnerabilit
This commit adds a DOWNSTREAM_OWNERS file to reflect OpenShift-appropriate Reviewers and Approvers.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Test of this rebase: openshift/external-dns-operator#163 |
@@ -0,0 +1,43 @@ | |||
name: Release Docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alebedev87 Have you looked at this new github workflow? It looks like it auto-generates docs and commits them back to the repo. I think it only happens if you create a tag with a version number, so if we don't tag our versions like that it probably won't matter, but it may be adding more commits that will make the next rebase a bit more work.
I think it's probably fine to leave this alone, but if it starts getting triggered, we may want to disable it like we did with dependabot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I didn't have a look at the github workflow. Yes, indeed it might have been a problem especially if we would make use of tags in this repository. Will have to see whether it'll give us some noise.
It looks good to me, but I'm going to add a hold for you to look at my other comment. If you don't think it needs to be changed, feel free to remove the hold. /lgtm |
/unhold |
/label qe-approved |
Upstream tag: v0.12.0
Whys: