Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase to upstream v0.14.2 #58

Merged
merged 1,337 commits into from
Sep 2, 2024
Merged

Rebase to upstream v0.14.2 #58

merged 1,337 commits into from
Sep 2, 2024

Conversation

jrosinsk and others added 30 commits February 9, 2024 07:07
* Update link to current workshop

The old link shows that the workshop has been updated and points you to a different one

* fix(pdns): provider implicitly changes CNAME to ALIAS

Fixes: kubernetes-sigs#3970

* feat: add debug message to CNAME to ALIAS conversion

Co-authored-by: Michel Loiseleur <[email protected]>

* fix(chart): Fix webhook install failure (kubernetes-sigs#4173)

* fix(chart): Fix webhook install failure

* chore(chart): Update chart metadata

* fix: provide possibility to have a soft error mode to only log error and not fatal

Signed-off-by: Sandor Szücs <[email protected]>

* fix: provide possibility to have a soft error mode to only log error and not fatal

Signed-off-by: Sandor Szücs <[email protected]>

* doc: add godoc

Signed-off-by: Sandor Szücs <[email protected]>

* [helm] Allow tpl in provider again (kubernetes-sigs#4180)

* [helm] Allow tpl in provider again

Signed-off-by: Jan-Otto Kröpke <[email protected]>

* bump version and changelog

Signed-off-by: Jan-Otto Kröpke <[email protected]>

* re-run helm-docs

Signed-off-by: Jan-Otto Kröpke <[email protected]>

---------

Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>

* Fix args for webhook deployment (kubernetes-sigs#4202)

* Fix args for webhook deployment

The upfront bullet point resulted in `- ""` and could brake the webhook container.

* Add changeloog

* add RBAC fix to namespaces - get, watch, list to each gateway-*route (kubernetes-sigs#4205)

* add RBAC fix to namespaces - get, watch, list to each gateway-*route

* fix conflicts

* resolve conflicts

* Apply suggestions from code review

Co-authored-by: Steve Hipwell <[email protected]>

---------

Co-authored-by: Steve Hipwell <[email protected]>

* chore: Released chart v1.14.3

Signed-off-by: Steve Hipwell <[email protected]>

* build(deps): bump the dev-dependencies group with 24 updates

Bumps the dev-dependencies group with 24 updates:

| Package | From | To |
| --- | --- | --- |
| [github.com/Azure/azure-sdk-for-go/sdk/azidentity](https://github.com/Azure/azure-sdk-for-go) | `1.4.0` | `1.5.1` |
| [github.com/F5Networks/k8s-bigip-ctlr/v2](https://github.com/F5Networks/k8s-bigip-ctlr) | `2.15.0` | `2.15.1` |
| [github.com/IBM/go-sdk-core/v5](https://github.com/IBM/go-sdk-core) | `5.15.0` | `5.15.1` |
| [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) | `1.62.652` | `1.62.673` |
| [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) | `1.49.15` | `1.50.9` |
| [github.com/civo/civogo](https://github.com/civo/civogo) | `0.3.56` | `0.3.58` |
| [github.com/cloudflare/cloudflare-go](https://github.com/cloudflare/cloudflare-go) | `0.85.0` | `0.87.0` |
| [github.com/digitalocean/godo](https://github.com/digitalocean/godo) | `1.107.0` | `1.108.0` |
| [github.com/infobloxopen/infoblox-go-client/v2](https://github.com/infobloxopen/infoblox-go-client) | `2.4.0` | `2.5.0` |
| [github.com/linode/linodego](https://github.com/linode/linodego) | `1.26.0` | `1.28.0` |
| [github.com/miekg/dns](https://github.com/miekg/dns) | `1.1.57` | `1.1.58` |
| [github.com/oracle/oci-go-sdk/v65](https://github.com/oracle/oci-go-sdk) | `65.55.0` | `65.57.0` |
| [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.834` | `1.0.856` |
| [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.834` | `1.0.856` |
| [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/privatedns](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.834` | `1.0.856` |
| [go.etcd.io/etcd/api/v3](https://github.com/etcd-io/etcd) | `3.5.11` | `3.5.12` |
| [go.etcd.io/etcd/client/v3](https://github.com/etcd-io/etcd) | `3.5.11` | `3.5.12` |
| [golang.org/x/oauth2](https://github.com/golang/oauth2) | `0.15.0` | `0.16.0` |
| [google.golang.org/api](https://github.com/googleapis/google-api-go-client) | `0.155.0` | `0.161.0` |
| [istio.io/api](https://github.com/istio/api) | `1.20.1` | `1.20.2` |
| [istio.io/client-go](https://github.com/istio/client-go) | `1.20.1` | `1.20.2` |
| [k8s.io/api](https://github.com/kubernetes/api) | `0.29.0` | `0.29.1` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.29.0` | `0.29.1` |
| [k8s.io/klog/v2](https://github.com/kubernetes/klog) | `2.110.1` | `2.120.1` |


Updates `github.com/Azure/azure-sdk-for-go/sdk/azidentity` from 1.4.0 to 1.5.1
- [Release notes](https://github.com/Azure/azure-sdk-for-go/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md)
- [Commits](Azure/azure-sdk-for-go@sdk/azcore/v1.4.0...sdk/internal/v1.5.1)

Updates `github.com/F5Networks/k8s-bigip-ctlr/v2` from 2.15.0 to 2.15.1
- [Release notes](https://github.com/F5Networks/k8s-bigip-ctlr/releases)
- [Changelog](https://github.com/F5Networks/k8s-bigip-ctlr/blob/v2.15.1/docs/RELEASE-NOTES.rst)
- [Commits](F5Networks/k8s-bigip-ctlr@v2.15.0...v2.15.1)

Updates `github.com/IBM/go-sdk-core/v5` from 5.15.0 to 5.15.1
- [Release notes](https://github.com/IBM/go-sdk-core/releases)
- [Changelog](https://github.com/IBM/go-sdk-core/blob/main/CHANGELOG.md)
- [Commits](IBM/go-sdk-core@v5.15.0...v5.15.1)

Updates `github.com/aliyun/alibaba-cloud-sdk-go` from 1.62.652 to 1.62.673
- [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases)
- [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt)
- [Commits](aliyun/alibaba-cloud-sdk-go@v1.62.652...v1.62.673)

Updates `github.com/aws/aws-sdk-go` from 1.49.15 to 1.50.9
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.49.15...v1.50.9)

Updates `github.com/civo/civogo` from 0.3.56 to 0.3.58
- [Release notes](https://github.com/civo/civogo/releases)
- [Changelog](https://github.com/civo/civogo/blob/master/changelog.yml)
- [Commits](civo/civogo@v0.3.56...v0.3.58)

Updates `github.com/cloudflare/cloudflare-go` from 0.85.0 to 0.87.0
- [Release notes](https://github.com/cloudflare/cloudflare-go/releases)
- [Changelog](https://github.com/cloudflare/cloudflare-go/blob/master/CHANGELOG.md)
- [Commits](cloudflare/cloudflare-go@v0.85.0...v0.87.0)

Updates `github.com/digitalocean/godo` from 1.107.0 to 1.108.0
- [Release notes](https://github.com/digitalocean/godo/releases)
- [Changelog](https://github.com/digitalocean/godo/blob/main/CHANGELOG.md)
- [Commits](digitalocean/godo@v1.107.0...v1.108.0)

Updates `github.com/infobloxopen/infoblox-go-client/v2` from 2.4.0 to 2.5.0
- [Release notes](https://github.com/infobloxopen/infoblox-go-client/releases)
- [Changelog](https://github.com/infobloxopen/infoblox-go-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/infobloxopen/infoblox-go-client/commits)

Updates `github.com/linode/linodego` from 1.26.0 to 1.28.0
- [Release notes](https://github.com/linode/linodego/releases)
- [Commits](linode/linodego@v1.26.0...v1.28.0)

Updates `github.com/miekg/dns` from 1.1.57 to 1.1.58
- [Changelog](https://github.com/miekg/dns/blob/master/Makefile.release)
- [Commits](miekg/dns@v1.1.57...v1.1.58)

Updates `github.com/oracle/oci-go-sdk/v65` from 65.55.0 to 65.57.0
- [Release notes](https://github.com/oracle/oci-go-sdk/releases)
- [Changelog](https://github.com/oracle/oci-go-sdk/blob/master/CHANGELOG.md)
- [Commits](oracle/oci-go-sdk@v65.55.0...v65.57.0)

Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common` from 1.0.834 to 1.0.856
- [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.834...v1.0.856)

Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod` from 1.0.834 to 1.0.856
- [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.834...v1.0.856)

Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/privatedns` from 1.0.834 to 1.0.856
- [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.834...v1.0.856)

Updates `go.etcd.io/etcd/api/v3` from 3.5.11 to 3.5.12
- [Release notes](https://github.com/etcd-io/etcd/releases)
- [Commits](etcd-io/etcd@v3.5.11...v3.5.12)

Updates `go.etcd.io/etcd/client/v3` from 3.5.11 to 3.5.12
- [Release notes](https://github.com/etcd-io/etcd/releases)
- [Commits](etcd-io/etcd@v3.5.11...v3.5.12)

Updates `golang.org/x/oauth2` from 0.15.0 to 0.16.0
- [Commits](golang/oauth2@v0.15.0...v0.16.0)

Updates `google.golang.org/api` from 0.155.0 to 0.161.0
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.155.0...v0.161.0)

Updates `istio.io/api` from 1.20.1 to 1.20.2
- [Commits](istio/api@1.20.1...1.20.2)

Updates `istio.io/client-go` from 1.20.1 to 1.20.2
- [Commits](istio/client-go@1.20.1...1.20.2)

Updates `k8s.io/api` from 0.29.0 to 0.29.1
- [Commits](kubernetes/api@v0.29.0...v0.29.1)

Updates `k8s.io/client-go` from 0.29.0 to 0.29.1
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.29.0...v0.29.1)

Updates `k8s.io/klog/v2` from 2.110.1 to 2.120.1
- [Release notes](https://github.com/kubernetes/klog/releases)
- [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md)
- [Commits](kubernetes/klog@v2.110.1...v2.120.1)

---
updated-dependencies:
- dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azidentity
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: github.com/F5Networks/k8s-bigip-ctlr/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: github.com/IBM/go-sdk-core/v5
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: github.com/aliyun/alibaba-cloud-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: github.com/civo/civogo
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: github.com/cloudflare/cloudflare-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: github.com/digitalocean/godo
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: github.com/infobloxopen/infoblox-go-client/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: github.com/linode/linodego
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: github.com/miekg/dns
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: github.com/oracle/oci-go-sdk/v65
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/privatedns
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: go.etcd.io/etcd/api/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: go.etcd.io/etcd/client/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: golang.org/x/oauth2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: google.golang.org/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: istio.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: istio.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: k8s.io/klog/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix "workload identity" spelling

* feat(aws-provider): create flag to support sub-domains match parent

The current implementation of external-dns from sig-external-dns does
not support domain filtering (--domain-filter) for sub-domains on Route53,
such as test.sub-domain.domain.com. The function MatchParent was recently
removed from the base code, but it is still necessary for this purpose.
An example of a use case for this support is having a cluster per hosted
zone with a hundred ingress related to that zone with different variants of
sub-domains. With the matchParent function and zone-match-parent flag,
external-dns will now support an extended automatic match for sub-domains.

* test(types): adding missing test to aws-zone-match-parent flag

* docs(aws-provider): add aws-zone-match-parent use

* docs(aws): refactor explanation of aws-zone-match-parent

* fix(aws-provider): add aws-zone-match-parent flag value to aws config

---------

Signed-off-by: Sandor Szücs <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Steve Hipwell <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Thomas Maroschik <[email protected]>
Co-authored-by: Michel Loiseleur <[email protected]>
Co-authored-by: Gabe Cook <[email protected]>
Co-authored-by: Sandor Szücs <[email protected]>
Co-authored-by: Jan-Otto Kröpke <[email protected]>
Co-authored-by: Tobias Bradtke <[email protected]>
Co-authored-by: orenlevi111 <[email protected]>
Co-authored-by: Steve Hipwell <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Greg Dubicki <[email protected]>
Co-authored-by: thiagoluiznunes <[email protected]>
cleanup: Drop additional docker files
chore: update the slack channel URL into the github support template
Add G-Core provider
Update the OCI Provider to incorporate SoftError to avoid CrashLoopBackoff
…ion-id-override

feat: enable Azure subscription ID override
Bumps the dev-dependencies group with 1 update: [helm/kind-action](https://github.com/helm/kind-action).


Updates `helm/kind-action` from 1.8.0 to 1.9.0
- [Release notes](https://github.com/helm/kind-action/releases)
- [Commits](helm/kind-action@dda0770...99576bf)

---
updated-dependencies:
- dependency-name: helm/kind-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
…ot/github_actions/dev-dependencies-d63955f9e9

build(deps): bump the dev-dependencies group with 1 update
…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables
Bumps the dev-dependencies group with 1 update: [GrantBirki/json-yaml-validate](https://github.com/grantbirki/json-yaml-validate).


Updates `GrantBirki/json-yaml-validate` from 2.6.0 to 2.6.1
- [Release notes](https://github.com/grantbirki/json-yaml-validate/releases)
- [Commits](GrantBirki/json-yaml-validate@v2.6.0...v2.6.1)

---
updated-dependencies:
- dependency-name: GrantBirki/json-yaml-validate
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the dev-dependencies group with 17 updates:

| Package | From | To |
| --- | --- | --- |
| [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) | `1.62.676` | `1.62.678` |
| [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) | `1.50.14` | `1.50.22` |
| [github.com/civo/civogo](https://github.com/civo/civogo) | `0.3.58` | `0.3.59` |
| [github.com/cloudflare/cloudflare-go](https://github.com/cloudflare/cloudflare-go) | `0.87.0` | `0.88.0` |
| [github.com/digitalocean/godo](https://github.com/digitalocean/godo) | `1.108.0` | `1.109.0` |
| [github.com/linode/linodego](https://github.com/linode/linodego) | `1.28.0` | `1.29.0` |
| [github.com/oracle/oci-go-sdk/v65](https://github.com/oracle/oci-go-sdk) | `65.58.0` | `65.59.0` |
| [github.com/projectcontour/contour](https://github.com/projectcontour/contour) | `1.27.0` | `1.28.1` |
| [github.com/scaleway/scaleway-sdk-go](https://github.com/scaleway/scaleway-sdk-go) | `1.0.0-beta.23` | `1.0.0-beta.24` |
| [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.857` | `1.0.859` |
| [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.857` | `1.0.859` |
| [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/privatedns](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.857` | `1.0.859` |
| [google.golang.org/api](https://github.com/googleapis/google-api-go-client) | `0.163.0` | `0.165.0` |
| gopkg.in/ns1/ns1-go.v2 | `2.7.13` | `2.8.0` |
| [k8s.io/api](https://github.com/kubernetes/api) | `0.29.1` | `0.29.2` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.29.1` | `0.29.2` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.29.1` | `0.29.2` |


Updates `github.com/aliyun/alibaba-cloud-sdk-go` from 1.62.676 to 1.62.678
- [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases)
- [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt)
- [Commits](aliyun/alibaba-cloud-sdk-go@v1.62.676...v1.62.678)

Updates `github.com/aws/aws-sdk-go` from 1.50.14 to 1.50.22
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.50.14...v1.50.22)

Updates `github.com/civo/civogo` from 0.3.58 to 0.3.59
- [Release notes](https://github.com/civo/civogo/releases)
- [Changelog](https://github.com/civo/civogo/blob/master/changelog.yml)
- [Commits](civo/civogo@v0.3.58...v0.3.59)

Updates `github.com/cloudflare/cloudflare-go` from 0.87.0 to 0.88.0
- [Release notes](https://github.com/cloudflare/cloudflare-go/releases)
- [Changelog](https://github.com/cloudflare/cloudflare-go/blob/master/CHANGELOG.md)
- [Commits](cloudflare/cloudflare-go@v0.87.0...v0.88.0)

Updates `github.com/digitalocean/godo` from 1.108.0 to 1.109.0
- [Release notes](https://github.com/digitalocean/godo/releases)
- [Changelog](https://github.com/digitalocean/godo/blob/main/CHANGELOG.md)
- [Commits](digitalocean/godo@v1.108.0...v1.109.0)

Updates `github.com/linode/linodego` from 1.28.0 to 1.29.0
- [Release notes](https://github.com/linode/linodego/releases)
- [Commits](linode/linodego@v1.28.0...v1.29.0)

Updates `github.com/oracle/oci-go-sdk/v65` from 65.58.0 to 65.59.0
- [Release notes](https://github.com/oracle/oci-go-sdk/releases)
- [Changelog](https://github.com/oracle/oci-go-sdk/blob/master/CHANGELOG.md)
- [Commits](oracle/oci-go-sdk@v65.58.0...v65.59.0)

Updates `github.com/projectcontour/contour` from 1.27.0 to 1.28.1
- [Release notes](https://github.com/projectcontour/contour/releases)
- [Changelog](https://github.com/projectcontour/contour/blob/main/RELEASES.md)
- [Commits](projectcontour/contour@v1.27.0...v1.28.1)

Updates `github.com/scaleway/scaleway-sdk-go` from 1.0.0-beta.23 to 1.0.0-beta.24
- [Release notes](https://github.com/scaleway/scaleway-sdk-go/releases)
- [Changelog](https://github.com/scaleway/scaleway-sdk-go/blob/master/CHANGELOG.md)
- [Commits](scaleway/scaleway-sdk-go@v1.0.0-beta.23...v1.0.0-beta.24)

Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common` from 1.0.857 to 1.0.859
- [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.857...v1.0.859)

Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod` from 1.0.857 to 1.0.859
- [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.857...v1.0.859)

Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/privatedns` from 1.0.857 to 1.0.859
- [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.857...v1.0.859)

Updates `google.golang.org/api` from 0.163.0 to 0.165.0
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.163.0...v0.165.0)

Updates `gopkg.in/ns1/ns1-go.v2` from 2.7.13 to 2.8.0

Updates `k8s.io/api` from 0.29.1 to 0.29.2
- [Commits](kubernetes/api@v0.29.1...v0.29.2)

Updates `k8s.io/apimachinery` from 0.29.1 to 0.29.2
- [Commits](kubernetes/apimachinery@v0.29.1...v0.29.2)

Updates `k8s.io/client-go` from 0.29.1 to 0.29.2
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.29.1...v0.29.2)

---
updated-dependencies:
- dependency-name: github.com/aliyun/alibaba-cloud-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: github.com/civo/civogo
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: github.com/cloudflare/cloudflare-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: github.com/digitalocean/godo
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: github.com/linode/linodego
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: github.com/oracle/oci-go-sdk/v65
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: github.com/projectcontour/contour
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: github.com/scaleway/scaleway-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/privatedns
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: google.golang.org/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: gopkg.in/ns1/ns1-go.v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
* feat: allow setting dnsConfig

* update docs

* fix docs

* Update charts/external-dns/templates/deployment.yaml

Co-authored-by: Steve Hipwell <[email protected]>

---------

Co-authored-by: Steve Hipwell <[email protected]>
…ot/go_modules/dev-dependencies-b3eccc524e

build(deps): bump the dev-dependencies group with 17 updates
…ot/github_actions/dev-dependencies-2faa2a9782

build(deps): bump the dev-dependencies group with 1 update
Bumps the dev-dependencies group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) | `1.62.678` | `1.62.680` |
| [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) | `1.50.22` | `1.50.24` |
| [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.859` | `1.0.861` |
| [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.859` | `1.0.861` |
| [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/privatedns](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.859` | `1.0.861` |
| [google.golang.org/api](https://github.com/googleapis/google-api-go-client) | `0.165.0` | `0.166.0` |


Updates `github.com/aliyun/alibaba-cloud-sdk-go` from 1.62.678 to 1.62.680
- [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases)
- [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt)
- [Commits](aliyun/alibaba-cloud-sdk-go@v1.62.678...v1.62.680)

Updates `github.com/aws/aws-sdk-go` from 1.50.22 to 1.50.24
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.50.22...v1.50.24)

Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common` from 1.0.859 to 1.0.861
- [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.859...v1.0.861)

Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod` from 1.0.859 to 1.0.861
- [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.859...v1.0.861)

Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/privatedns` from 1.0.859 to 1.0.861
- [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.859...v1.0.861)

Updates `google.golang.org/api` from 0.165.0 to 0.166.0
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.165.0...v0.166.0)

---
updated-dependencies:
- dependency-name: github.com/aliyun/alibaba-cloud-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/privatedns
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: google.golang.org/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
…ot/go_modules/dev-dependencies-701aa56372

build(deps): bump the dev-dependencies group with 6 updates
docs: 📝 add Azure DNS w/workload identity blog post to readme
@openshift-ci openshift-ci bot requested review from miheer and rfredette August 5, 2024 09:42
@alebedev87
Copy link
Author

Test PR with the image pushed manually: openshift/external-dns-operator#223.

@alebedev87
Copy link
Author

/retest

@alebedev87
Copy link
Author

alebedev87 commented Aug 5, 2024

The last commit amended with no changes to retrigger tests modified in openshift/release#55189.

@alebedev87
Copy link
Author

/retest

…ty view

This commit addresses an issue introduced in PR#3560.

*Problem Description*
The search parameters are now always set for requests to WAPI.
This includes the view parameter, even if it's an empty string (the default value).
CNAME and TXT record types embed the view as a "string pointer" type,
so even an empty string is included in the request body to the WAPI.

The WAPI treats a view with an empty string value differently from a view that is not set at all.
The latter case results in using the default view, while the former tries to get a view
with an empty string value, causing an error: "View  not found".

*Fix*
The fix consists in not setting the view field for CNAME and TXT record objects
if the view is an empty string. This will effectively skip the view field from marshalling
into the request and allow the WAPI to use the default view.

*Note*
The problem didn't show up when externaldns was used with the new webhook provider for Infoblox.
Therefore this commit can be dropped once the Infoblox provider removed from the main codebase of externaldns.
@alebedev87
Copy link
Author

alebedev87 commented Aug 7, 2024

New carry patch was added to address the problem with the creation of CNAME and TXT records with Infoblox provider. The problem was initially addressed by adding "default" as the default view but then rethought and addressed as a patch. This carry patch won't need to be pushed upstream because the upstream has already moved the Infoblox provider to a dedicated webhook repository which didn't show the problem.
See also the test PR with this carry patch which passed all the e2e tests.

Copy link

openshift-ci bot commented Aug 7, 2024

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rfredette
Copy link

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2024
Copy link

openshift-ci bot commented Aug 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfredette

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2024
@jmanthei
Copy link

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Aug 28, 2024
@alebedev87
Copy link
Author

/label px-approved

No TE needed for this feature, release notes are enough.

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Aug 28, 2024
@melvinjoseph86
Copy link

Tested the pr using cluster bot, basic functionality is working. Hence approving from QE side.
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 441588e into master Sep 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.