-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws/permissions: Add s3:GetBucketObjectLockConfiguration to pre-flight checks #1491
aws/permissions: Add s3:GetBucketObjectLockConfiguration to pre-flight checks #1491
Conversation
…nfiguration And alphabetize this section. The new permission avoids [1]: error getting S3 Bucket Object Lock configuration: AccessDenied which came in with our Terraform bump from d1c17b7 (terraform/exec/plugins/vendor: Bump terraform-provider-aws to v2.2.0, 2019-03-19, openshift#1442). [1]: hashicorp/terraform-provider-aws#7550
From @csrwng:
so I don't think we're missing anything else. It would be nice to have CI coverage to ensure that our set of required permissions was sufficient (even if it would be hard to ensure it was minimal), but I'm punting all of that to follow-up work. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
/retest |
And alphabetize this section. The new permission avoids:
which came in with our Terraform bump from d1c17b7 (#1442).