Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws/permissions: Add s3:GetBucketObjectLockConfiguration to pre-flight checks #1491

Conversation

wking
Copy link
Member

@wking wking commented Mar 28, 2019

And alphabetize this section. The new permission avoids:

error getting S3 Bucket Object Lock configuration: AccessDenied

which came in with our Terraform bump from d1c17b7 (#1442).

…nfiguration

And alphabetize this section.  The new permission avoids [1]:

  error getting S3 Bucket Object Lock configuration: AccessDenied

which came in with our Terraform bump from d1c17b7
(terraform/exec/plugins/vendor: Bump terraform-provider-aws to v2.2.0,
2019-03-19, openshift#1442).

[1]: hashicorp/terraform-provider-aws#7550
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 28, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2019
@wking
Copy link
Member Author

wking commented Mar 28, 2019

From @csrwng:

btw, install is progressing now with the new permission

so I don't think we're missing anything else. It would be nice to have CI coverage to ensure that our set of required permissions was sufficient (even if it would be hard to ensure it was minimal), but I'm punting all of that to follow-up work.

@abhinavdahiya abhinavdahiya changed the title pkg/asset/installconfig/aws/permissions: Add s3:GetBucketObjectLockConfiguration aws/permissions: Add s3:GetBucketObjectLockConfiguration to pre-flight checks Mar 28, 2019
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavdahiya
Copy link
Contributor

Failing tests:

[Feature:DeploymentConfig] deploymentconfigs when run iteratively [Conformance] should only deploy the last deployment [Suite:openshift/conformance/parallel/minimal]

/retest

@wking
Copy link
Member Author

wking commented Mar 29, 2019

e2e-aws:

level=fatal msg="waiting for Kubernetes API: context deadline exceeded"

/retest

@wking
Copy link
Member Author

wking commented Mar 29, 2019

e2e-aws:

Flaky tests:

[sig-cli] Kubectl client [k8s.io] Kubectl logs should be able to retrieve and filter logs  [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]

Failing tests:

[Feature:Platform] Managed cluster should have no crashlooping pods in core namespaces over two minutes [Suite:openshift/conformance/parallel]

/retest

@openshift-merge-robot openshift-merge-robot merged commit e7ce76d into openshift:master Mar 29, 2019
@wking wking deleted the require-s3-GetBucketObjectLockConfiguration branch March 29, 2019 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants