vsphere: Close a possible race with Ignition firstboot completion

[cgwalters]

I was looking at https://bugzilla.redhat.com/show_bug.cgi?id=1762509
and that linked to this code (I don't quite understand why
we're rebooting here...this code really needs like some comments)
but anyways one possible issue I see here is that we will
race with ignition-firstboot-complete.service.

I'm going to fix FCOS so that service runs much earlier too,
but let's add this ordering here.

And someone please explain in some comments what is going on
here.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cgwalters
To complete the pull request process, please assign staebler
You can assign the PR to them by writing /assign @staebler in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• upi/vsphere/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cgwalters]

coreos/ignition-dracut#124

[jcpowermac]

I was looking at https://bugzilla.redhat.com/show_bug.cgi?id=1762509
and that linked to this code (I don't quite understand why
we're rebooting here...this code really needs like some comments)
but anyways one possible issue I see here is that we will
race with ignition-firstboot-complete.service.

I'm going to fix FCOS so that service runs much earlier too,
but let's add this ordering here.

And someone please explain in some comments what is going on
here.

@staebler @dav1x this was before my time working on this any ideas for the need of the reboot?

[jcpowermac]

/test e2e-vsphere

[staebler]

@staebler @dav1x this was before my time working on this any ideas for the need of the reboot?

My recollection is that the reboot was there to ensure that the static IP configuration took effect. It may not be necessary any more. Does that sounds like what you remember from that, @dav1x?

[cgwalters]

In RHCOS today we teardown the Ignition network (DHCP) by default for exactly this reason:
coreos/ignition-dracut#78
Which we were later considering reverting coreos/ignition-dracut#122
but didn't due to this use case.

So it should work without rebooting.

[dav1x]

Yes, this was prior to the change in rhcos where the network was configured at the time of the ignition application. This was meant to activate the static ip configuration from ignition after the system was idle. This can probably be removed now.

[sdodson]

/retest

[openshift-ci-robot]

@cgwalters: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-openstack	dc9889c	link	/test e2e-openstack
ci/prow/e2e-vsphere	dc9889c	link	/test e2e-vsphere

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[patrickdillon]

I will defer to the experts here.
/unassign @patrickdillon

[cgwalters]

/close
We'll ship a fix for this in RHCOS 4.3 soon.

[openshift-ci-robot]

@cgwalters: Closed this PR.

In response to this:

/close
We'll ship a fix for this in RHCOS 4.3 soon.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.