Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Print the "export KUBECONFIG=..." command on its own line for easier cut-and-paste #8882

Conversation

danwinship
Copy link
Contributor

A long time ago I submitted a PR (#6018) to change the installer output from

INFO To access the cluster as the system:admin user when using 'oc',
run 'export KUBECONFIG=/path/to/installer/auth/kubeconfig'

to

INFO To access the cluster as the system:admin user when using 'oc', run
    export KUBECONFIG=/path/to/installer/auth/kubeconfig

for ease of cut-and-pasting, but then a few months later it accidentally got reverted due to a badly-resolved merge conflict in #5336.

This just puts it back to how it was in #6018 (which, FTR, is how README.md still claims it prints it).

@openshift-ci openshift-ci bot requested review from r4f4 and rna-afk August 20, 2024 15:23
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2024
@sadasu
Copy link
Contributor

sadasu commented Aug 20, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2024
Copy link
Contributor

openshift-ci bot commented Aug 20, 2024

@danwinship: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danwinship danwinship changed the title Print the "export KUBECONFIG=..." command on its own line for easier cut-and-paste NO-JIRA: Print the "export KUBECONFIG=..." command on its own line for easier cut-and-paste Aug 20, 2024
@openshift-ci-robot
Copy link
Contributor

@danwinship: This pull request explicitly references no jira issue.

In response to this:

A long time ago I submitted a PR (#6018) to change the installer output from

INFO To access the cluster as the system:admin user when using 'oc',
run 'export KUBECONFIG=/path/to/installer/auth/kubeconfig'

to

INFO To access the cluster as the system:admin user when using 'oc', run
   export KUBECONFIG=/path/to/installer/auth/kubeconfig

for ease of cut-and-pasting, but then a few months later it accidentally got reverted due to a badly-resolved merge conflict in #5336.

This just puts it back to how it was in #6018 (which, FTR, is how README.md still claims it prints it).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f6b2c7d into openshift:master Aug 20, 2024
17 checks passed
@danwinship danwinship deleted the kubeconfig-command-copyability-again branch August 20, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants