Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-36532: Agent installer wait-for, just test connectivity to host #9074

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bfournie
Copy link
Contributor

@bfournie bfournie commented Oct 4, 2024

In the agent wait-for, when the APIs are not available, an attempt is made to check the host by ssh'ing to it. This results in confusing debug messages if the keys aren't present. This changes the check to just test connectivity to the host.

In the agent wait-for, when the APIs are not available, an attempt is
made to check the host by ssh'ing to it. This results in confusing
debug messages if the keys aren't present. This changes the check to
just test connectivity to the host.
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Oct 4, 2024
@openshift-ci-robot
Copy link
Contributor

@bfournie: This pull request references Jira Issue OCPBUGS-36532, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In the agent wait-for, when the APIs are not available, an attempt is made to check the host by ssh'ing to it. This results in confusing debug messages if the keys aren't present. This changes the check to just test connectivity to the host.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 4, 2024
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bfournie. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bfournie
Copy link
Contributor Author

bfournie commented Oct 4, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 4, 2024
@openshift-ci-robot
Copy link
Contributor

@bfournie: This pull request references Jira Issue OCPBUGS-36532, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from mhanss October 4, 2024 19:07
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

@bfournie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage 7fa1ef5 link false /test e2e-agent-compact-ipv4-appliance-diskimage
ci/prow/images 7fa1ef5 link true /test images
ci/prow/e2e-agent-compact-ipv4-add-nodes 7fa1ef5 link false /test e2e-agent-compact-ipv4-add-nodes
ci/prow/e2e-agent-sno-ipv6 7fa1ef5 link false /test e2e-agent-sno-ipv6
ci/prow/okd-verify-codegen 7fa1ef5 link true /test okd-verify-codegen
ci/prow/e2e-agent-ha-dualstack 7fa1ef5 link false /test e2e-agent-ha-dualstack
ci/prow/e2e-agent-compact-ipv4 7fa1ef5 link true /test e2e-agent-compact-ipv4
ci/prow/integration-tests 7fa1ef5 link true /test integration-tests
ci/prow/e2e-agent-sno-ipv4-pxe 7fa1ef5 link false /test e2e-agent-sno-ipv4-pxe

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants