This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

[Backport] [Release 0.23] Use transformers to extract metrics for Kafka #1318

Merged

openshift-merge-robot merged 4 commits into openshift:release-v0.23 from skonto:use_transformers_23

Jun 17, 2021

skonto commented Jun 16, 2021 •

edited

Loading

Same as in #1316, cherry picked the related commits from main upstream. I will the create a PR against eventing-kafka 0.23, this is for aligning the code bases.

skonto added 4 commits

June 16, 2021 16:24


          make eventing metrics generic (knative#5478)

d2c2908


          Expose dispatch result to be used by other implementations (knative#5481

d6973ca

)

* expose dispatch result to be used by other implementations

* expose fields

* add getters etc

* less verbose


          Use transformers efficiently for extracting info for metrics in Kafka…

91c5291

… Channel (knative#5505)

* use transformers for extracting event type for metrics

* fix

* fix


          pass transformers to executeRequest (knative#5512)

11be12f

skonto changed the title ~~[Release 0.23] Use transformers to extract metrics for Kafka~~ [Backport] [Release 0.23] Use transformers to extract metrics for Kafka

openshift-ci bot requested review from alanfx and matzew

June 16, 2021 13:46

openshift-ci bot added the approved label

Author

skonto commented Jun 16, 2021

/assign @slinkydeveloper

openshift-ci bot assigned slinkydeveloper

slinkydeveloper commented Jun 16, 2021

/lgtm
/approve

openshift-ci bot added the lgtm label

openshift-ci bot commented Jun 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

11 similar comments

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jun 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jun 17, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Jun 17, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot merged commit f7036f2 into openshift:release-v0.23

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels