Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: UPSTREAM:<drop>: bump openshift/library-go@4d55b6d #2068

Merged
merged 1 commit into from
Aug 29, 2024
Merged

NO-JIRA: UPSTREAM:<drop>: bump openshift/library-go@4d55b6d #2068

merged 1 commit into from
Aug 29, 2024

Conversation

sohankunkerkar
Copy link
Member

To fix the safe sysctls list in OCP.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Addresses: https://issues.redhat.com/browse/OCPBUGS-38149

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 28, 2024
@openshift-ci-robot
Copy link

@sohankunkerkar: Jira Issue OCPBUGS-38149 is in a security level that is not in the allowed security levels for this repo.
Allowed security levels for this repo are:

  • Red Hat Employee
  • default

In response to this:

To fix the safe sysctls list in OCP.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Addresses: https://issues.redhat.com/browse/OCPBUGS-38149

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@sohankunkerkar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@sohankunkerkar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Aug 28, 2024
@openshift-ci-robot
Copy link

@sohankunkerkar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

bertinatto
bertinatto reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use hack/pin-dependency.sh and hack/update-vendor.sh instead. This will update a few more files. Also, please amend your commit message to make it a <drop> instead.

Finally, a small nit: please update the title with the correct dependency.

@openshift-ci-robot
Copy link

@sohankunkerkar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@sohankunkerkar sohankunkerkar changed the title OCPBUGS-38149: vendor: bump openshift/library-go@4d55b6dd978f OCPBUGS-38149: vendor: bump openshift/library-go@4d55b6d Aug 29, 2024
@sohankunkerkar sohankunkerkar changed the title OCPBUGS-38149: vendor: bump openshift/library-go@4d55b6d OCPBUGS-38149: UPSTREAM:<drop>: vendor: bump openshift/library-go@4d55b6d Aug 29, 2024
@openshift-ci-robot
Copy link

@sohankunkerkar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@sohankunkerkar
UPSTREAM: <drop>: bump(github.com/openshift/apiserver-library-go)
a4376ee 
./hack/pin-dependency.sh github.com/openshift/apiserver-library-go 4d55b6d
./hack/update-vendor.sh

Signed-off-by: Sohan Kunkerkar <[email protected]>
@openshift-ci-robot
Copy link

@sohankunkerkar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@sohankunkerkar sohankunkerkar changed the title OCPBUGS-38149: UPSTREAM:<drop>: vendor: bump openshift/library-go@4d55b6d OCPBUGS-38149: UPSTREAM:<drop>: bump openshift/library-go@4d55b6d Aug 29, 2024
@sohankunkerkar
Copy link
Member Author

Please use hack/pin-dependency.sh and hack/update-vendor.sh instead. This will update a few more files. Also, please amend your commit message to make it a <drop> instead.

Finally, a small nit: please update the title with the correct dependency.

Thanks!
I have addressed your comments in the latest push.
@p0lyn0mial @bertinatto PTAL

@p0lyn0mial
Copy link

LGTM

I will defer to @bertinatto for tagging it.

@sohankunkerkar
Copy link
Member Author

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 29, 2024

@sohankunkerkar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

bertinatto
bertinatto reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
@sohankunkerkar sohankunkerkar changed the title OCPBUGS-38149: UPSTREAM:<drop>: bump openshift/library-go@4d55b6d NO-JIRA: UPSTREAM:<drop>: bump openshift/library-go@4d55b6d Aug 29, 2024
@openshift-ci-robot
Copy link

@sohankunkerkar: This pull request explicitly references no jira issue.

In response to this:

To fix the safe sysctls list in OCP.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Addresses: https://issues.redhat.com/browse/OCPBUGS-38149

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 29, 2024
@sohankunkerkar
Copy link
Member Author

/validate-backports

@openshift-ci-robot
Copy link

@sohankunkerkar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@sohankunkerkar
Copy link
Member Author

/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 29, 2024

@sohankunkerkar: Can not set label backports/validated-commits: Must be member in one of these teams: [openshift-staff-engineers]

In response to this:

/remove-label backports/unvalidated-commits
/label backports/validated-commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 29, 2024

@sohankunkerkar: Can not set label backports/unvalidated-commits: Must be member in one of these teams: [openshift-staff-engineers]

In response to this:

/remove-label backports/unvalidated-commits
/label backports/validated-commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bertinatto
Copy link
Member

/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Aug 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8188633 into openshift:master Aug 29, 2024
20 checks passed
@sohankunkerkar sohankunkerkar deleted the update-apiserver-library-go branch August 29, 2024 17:21
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.18.0-202408301116.p0.g8188633.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.18.0-202408301116.p0.g8188633.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.18.0-202408301116.p0.g8188633.assembly.stream.el9.
All builds following this will include this PR.

@sohankunkerkar sohankunkerkar mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@tkashem tkashem Awaiting requested review from tkashem

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sohankunkerkar @openshift-ci-robot @p0lyn0mial @bertinatto @openshift-bot