test: added check for snapshot and clone creation in e2e #206

riya-singhal31 · 2022-06-13T12:06:49Z

It creates snapshots and clones and check if the cloned PVC is bound or not.

Signed-off-by: riya-singhal31 [email protected]

nbalacha

Please include a test to restore the snapshot as we...

nbalacha · 2022-06-16T06:29:49Z

e2e/testdata.go

+}
+
+func GetSampleClone(quantity, name string, volumemode k8sv1.PersistentVolumeMode) *k8sv1.PersistentVolumeClaim {
+	storageClassName := "odf-lvm-vg1"


Please pass this as an argument. Then if we change the storageclass name, it only has to be changed in one place. Comment holds for all instances of this usage.

sp98 · 2022-06-17T06:53:45Z

e2e/lvm/pvc_test.go

@@ -25,6 +26,12 @@ func PVCTest() {
 		var filepod *k8sv1.Pod
 		var blockpvc *k8sv1.PersistentVolumeClaim
 		var blockpod *k8sv1.Pod
+		var fileSnapshot *snapapi.VolumeSnapshot
+		var blockSnapshot *snapapi.VolumeSnapshot
+		var filepvcclone *k8sv1.PersistentVolumeClaim


The names should follow the camelcase convention.

riya-singhal31 · 2022-06-22T08:06:10Z

O/P:

[riyasinghal@fedora lvm-operator]$ oc get pvc,pods -n lvm-endtoendtest
NAME STATUS VOLUME CAPACITY ACCESS MODES STORAGECLASS AGE
persistentvolumeclaim/lvmblockpvc Bound pvc-f6d06c9f-f97c-4cf1-af0e-66b99bd7c8ee 5Gi RWO odf-lvm-vg1 112s
persistentvolumeclaim/lvmblockpvcclone Bound pvc-72eaeaf8-f515-465d-b679-b0c28256dfac 5Gi RWO odf-lvm-vg1 82s
persistentvolumeclaim/lvmblockpvcsnapshotrestore Bound pvc-cb66278a-a18e-48cf-931b-631c1fac79a3 5Gi RWO odf-lvm-vg1 51s
persistentvolumeclaim/lvmfilepvc Bound pvc-845197bc-903f-4179-9b11-6cfa1b59eff3 5Gi RWO odf-lvm-vg1 3m23s
persistentvolumeclaim/lvmfilepvcclone Bound pvc-3342fac2-3532-48fb-8e5f-13e05d98f96f 5Gi RWO odf-lvm-vg1 2m53s
persistentvolumeclaim/lvmfilepvcsnapshotrestore Bound pvc-d34f9780-837f-41e3-b089-fa79fdfc5c8d 5Gi RWO odf-lvm-vg1 2m22s

NAME READY STATUS RESTARTS AGE
pod/clone-lvmblockpod 1/1 Running 0 81s
pod/clone-lvmfilepod 1/1 Running 0 2m53s
pod/lvmblockpod 1/1 Running 0 112s
pod/lvmfilepod 1/1 Running 0 3m23s
pod/restore-lvmblockpod 1/1 Running 0 51s
pod/restore-lvmfilepod 1/1 Running 0 2m22s

[riyasinghal@fedora lvm-operator]$ oc get volumesnapshot -n lvm-endtoendtest
NAME READYTOUSE SOURCEPVC SOURCESNAPSHOTCONTENT RESTORESIZE SNAPSHOTCLASS SNAPSHOTCONTENT CREATIONTIME AGE
lvmblockpvcsnapshot true lvmblockpvc 5Gi odf-lvm-vg1 snapcontent-b9123e0e-1d08-436d-a3ef-147d884565b6 75s 75s
lvmfilepvcsnapshot true lvmfilepvc 5Gi odf-lvm-vg1 snapcontent-a608b6ad-d2a5-4074-b9e2-db7b1680dec6 2m46s 2m46s

nbalacha · 2022-06-24T04:57:02Z

e2e/lvm/pvc_test.go

+		var restoreBlockPod *k8sv1.Pod
+
+		Context("create pvc, pod, snapshots, clones", func() {
+			It("Verifies the status for filepvc", func() {
 				By("Creates pvc and pod")


Suggested change

By("Creates pvc and pod")

By("Creating pvc and pod")

nbalacha · 2022-06-24T04:57:37Z

e2e/lvm/pvc_test.go

-				filepvc = tests.GetSamplePVC(tests.StorageClass, "5Gi", "lvmfilepvc", k8sv1.PersistentVolumeFilesystem)
-				filepod = tests.GetSamplePod("lvmfilepod", "lvmfilepvc")
-				err := tests.DeployManagerObj.GetCrClient().Create(context.TODO(), filepvc)
+				filePvc = tests.GetSamplePVC(tests.StorageClass, quantity, "lvmfilepvc", k8sv1.PersistentVolumeFilesystem)


Suggested change

filePvc = tests.GetSamplePVC(tests.StorageClass, quantity, "lvmfilepvc", k8sv1.PersistentVolumeFilesystem)

filePvc = tests.GetSamplePVC(tests.StorageClass, size, "lvmfilepvc", k8sv1.PersistentVolumeFilesystem)

Please rename the variable to size. Quantity sounds more like count.

nbalacha · 2022-06-24T05:00:19Z

e2e/lvm/pvc_test.go

-				err := tests.DeployManagerObj.GetCrClient().Create(context.TODO(), filepvc)
+				filePvc = tests.GetSamplePVC(tests.StorageClass, quantity, "lvmfilepvc", k8sv1.PersistentVolumeFilesystem)
+				filePod = tests.GetSamplePod("lvmfilepod", filePvc.Name)
+				err := tests.DeployManagerObj.GetCrClient().Create(context.TODO(), filePvc)


Instead of calling tests.DeployManagerObj.GetCrClient() everywhere, please save this to a variable in the beginning and use that everywhere.

nbalacha · 2022-06-24T05:01:23Z

e2e/lvm/pvc_test.go

-				blockpvc = tests.GetSamplePVC(tests.StorageClass, "5Gi", "lvmblockpvc", k8sv1.PersistentVolumeBlock)
-				blockpod = tests.GetSamplePod("lvmblockpod", "lvmblockpvc")
-				err = tests.DeployManagerObj.GetCrClient().Create(context.TODO(), blockpvc)
+				By("PVC(file system) Should be bound and Pod should be running")


Suggested change

By("PVC(file system) Should be bound and Pod should be running")

By("Verifying that the PVC(file system) is bound and the Pod is running")

nbalacha · 2022-06-24T05:02:23Z

e2e/lvm/pvc_test.go

+				}, timeout, interval).Should(BeTrue())
+				fmt.Printf("Pod %s is running\n", filePod.Name)
+
+				By("Snapshot for file-pvc")


Suggested change

By("Snapshot for file-pvc")

By("Creating a Snapshot of the file-pvc")

nbalacha · 2022-06-24T05:20:57Z

e2e/lvm/pvc_test.go

+				Expect(err).To(BeNil())
+				fmt.Printf("Clone PVC %s is deleted\n", blockPvcClone.Name)
+
+				err = tests.DeployManagerObj.GetCrClient().Delete(context.TODO(), blockPvcRestore)


Suggested change

err = tests.DeployManagerObj.GetCrClient().Delete(context.TODO(), blockPvcRestore)

err = tests.DeployManagerObj.GetCrClient().Delete(context.TODO(), restoreBlockPod)

nbalacha · 2022-06-24T05:21:30Z

e2e/lvm/pvc_test.go

+				Expect(err).To(BeNil())
+				fmt.Printf("Clone PVC %s is deleted\n", filePvcClone.Name)
+
+				err = tests.DeployManagerObj.GetCrClient().Delete(context.TODO(), filePvcRestore)


Suggested change

err = tests.DeployManagerObj.GetCrClient().Delete(context.TODO(), filePvcRestore)

err = tests.DeployManagerObj.GetCrClient().Delete(context.TODO(), restoreFilePod)

nbalacha · 2022-06-24T05:23:51Z

e2e/testdata.go

+	return vs
+}
+
+func GetSampleClone(quantity, name string, volumemode k8sv1.PersistentVolumeMode, storageClass string) *k8sv1.PersistentVolumeClaim {


Suggested change

func GetSampleClone(quantity, name string, volumemode k8sv1.PersistentVolumeMode, storageClass string) *k8sv1.PersistentVolumeClaim {

func GetSampleClone(size, name string, volumemode k8sv1.PersistentVolumeMode, storageClass string) *k8sv1.PersistentVolumeClaim {

nbalacha · 2022-06-24T05:24:23Z

e2e/testdata.go

+	return pvc
+}
+
+func GetRestoreVolume(quantity, name string, storageClass string) *k8sv1.PersistentVolumeClaim {


Suggested change

func GetRestoreVolume(quantity, name string, storageClass string) *k8sv1.PersistentVolumeClaim {

func GetRestoreVolume(size, name string, storageClass string) *k8sv1.PersistentVolumeClaim {

You can also consider defining resources the way topolvm does for its e2e tests.

nbalacha · 2022-06-24T05:24:59Z

e2e/testdata.go

+	return vs
+}
+
+func GetSampleClone(quantity, name string, volumemode k8sv1.PersistentVolumeMode, storageClass string) *k8sv1.PersistentVolumeClaim {


Combine the clone and restore functions into a single one taking a sourceType argument. The rest of the code is the same.

riya-singhal31 · 2022-06-27T12:56:01Z

Thanks @nbalacha for your suggestions, have addressed them all.

nbalacha · 2022-06-28T06:36:57Z

e2e/lvm/pvc_test.go

+		var clonePod *k8sv1.Pod
+		var restorePvc *k8sv1.PersistentVolumeClaim
+		var restorePod *k8sv1.Pod
+		test := tests.DeployManagerObj.GetCrClient()


Suggested change

test := tests.DeployManagerObj.GetCrClient()

client := tests.DeployManagerObj.GetCrClient()

nbalacha · 2022-06-28T06:38:03Z

e2e/lvm/pvc_test.go

+				By("Creating pvc and pod")
+				pvc = tests.GetSamplePVC(tests.StorageClass, size, "lvmfilepvc", k8sv1.PersistentVolumeFilesystem)
+				pod = tests.GetSamplePod("lvmfilepod", pvc.Name)
+				err := test.Create(context.TODO(), pvc)


Are these resources cleaned up in case of error?

In the end, we are deleting this namespace only, so anyway all of these will get removed.

nbalacha · 2022-06-28T06:46:53Z

e2e/lvm/pvc_test.go

+				fmt.Printf("Snapshot %s is created\n", snapshot.Name)
+
+				By("Creating a clone of the file-pvc")
+				clonePvc = tests.GetPvc(size, pvc.Name, k8sv1.PersistentVolumeFilesystem, tests.StorageClass, "clone", "PersistentVolumeClaim")


Any input should be in terms of the PVC being cloned. For example:
clonePvc = tests.GetPvc(pvc.size, pvc.Name, pvc.AccessMode, tests.StorageClass, "clone")

The last argument can be removed.
If sourceType== clone, it is of type PVC.
If sourceType==snapshot, it is of type VolumeSnapshot.

nbalacha · 2022-06-28T06:48:41Z

e2e/lvm/pvc_test.go

+				fmt.Printf("Cloned PVC %s is bound\n", clonePvc.Name)
+
+				By("Restore Snapshot for file-pvc")
+				restorePvc = tests.GetPvc(size, pvc.Name+"snapshot", k8sv1.PersistentVolumeFilesystem, tests.StorageClass, "restore", "VolumeSnapshot")


Restoring a snapshot will create a PVC, not a snapshot.

I have passed snapshot as string here(pvc.Name+"snapshot") to specify the dataSource, as this is the format I used to name the snapshot.

nbalacha

Can the GetSamplePVC be extended to do what GetPVC is doing?

nbalacha · 2022-07-07T06:37:09Z

e2e/testdata.go

+}
+
+// GetSamplePvc returns restore or clone of the pvc based on the kind(kindName) provided.
+func GetSamplePvc(size, name string, volumemode k8sv1.PersistentVolumeMode, storageClass string, sourceType string) *k8sv1.PersistentVolumeClaim {


Please refactor to something like this:

func GetSamplePvc(size, name string, volumemode k8sv1.PersistentVolumeMode, storageClass string, sourceType, sourceName string) *k8sv1.PersistentVolumeClaim { var kindName string var sourceName string pvc := &k8sv1.PersistentVolumeClaim{ ObjectMeta: metav1.ObjectMeta{ Name: name, Namespace: TestNamespace, }, Spec: k8sv1.PersistentVolumeClaimSpec{ StorageClassName: &storageClass, AccessModes: []k8sv1.PersistentVolumeAccessMode{k8sv1.ReadWriteOnce}, VolumeMode: &volumemode, Resources: k8sv1.ResourceRequirements{ Requests: k8sv1.ResourceList{ k8sv1.ResourceStorage: resource.MustParse(size), }, }, }, } if sourceType != "" && sourceName != "" { pvc.Spec.DataSource = &k8sv1.TypedLocalObjectReference{ Name: sourceName, Kind: sourceType, }, } return pvc }

nbalacha · 2022-07-07T06:37:39Z

e2e/testdata.go

@@ -61,3 +44,62 @@ func GetSamplePod(name, pvcName string) *k8sv1.Pod {
 	}
 	return pod
 }
+
+// GetSampleVolumeSnapshot creates and returns the VolumeSnapshot for the provided PVC.
+func GetSampleVolumeSnapshot(name string, storageClass string) *snapapi.VolumeSnapshot {


Suggested change

func GetSampleVolumeSnapshot(name string, storageClass string) *snapapi.VolumeSnapshot {

func GetSampleVolumeSnapshot(name string, storageClass string, sourceName string) *snapapi.VolumeSnapshot {

nbalacha · 2022-07-07T06:38:08Z

e2e/testdata.go

+	vs := &snapapi.VolumeSnapshot{
+		ObjectMeta: metav1.ObjectMeta{
+			// name = name of pvc + snapshot
+			Name:      name + "snapshot",


Suggested change

Name: name + "snapshot",

Name: name,

nbalacha · 2022-07-07T06:38:28Z

e2e/testdata.go

+		Spec: snapapi.VolumeSnapshotSpec{
+			VolumeSnapshotClassName: &storageClass,
+			Source: snapapi.VolumeSnapshotSource{
+				PersistentVolumeClaimName: &name,


Suggested change

PersistentVolumeClaimName: &name,

PersistentVolumeClaimName: &sourceName,

…apshot-clone

nbalacha · 2022-07-08T06:36:33Z

e2e/lvm/pvc_test.go

+				fmt.Printf("Snapshot %s is created\n", snapshot.Name)
+
+				By("Creating a clone of the file-pvc")
+				clonePvc = tests.GetSamplePvc(size, pvc.Name, k8sv1.PersistentVolumeFilesystem, tests.StorageClass, "PersistentVolumeClaim", pvc.Name)


Suggested change

clonePvc = tests.GetSamplePvc(size, pvc.Name, k8sv1.PersistentVolumeFilesystem, tests.StorageClass, "PersistentVolumeClaim", pvc.Name)

clonePvc = tests.GetSamplePvc(size, pvc.Name + "-clone", k8sv1.PersistentVolumeFilesystem, tests.StorageClass, "PersistentVolumeClaim", pvc.Name)

nbalacha · 2022-07-08T06:38:06Z

e2e/lvm/pvc_test.go


-				err = tests.DeployManagerObj.GetCrClient().Delete(context.TODO(), filepvc)
+				By("Creating a clone of the block-pvc")
+				clonePvc = tests.GetSamplePvc(size, pvc.Name, k8sv1.PersistentVolumeBlock, tests.StorageClass, "PersistentVolumeClaim", pvc.Name)


Suggested change

clonePvc = tests.GetSamplePvc(size, pvc.Name, k8sv1.PersistentVolumeBlock, tests.StorageClass, "PersistentVolumeClaim", pvc.Name)

clonePvc = tests.GetSamplePvc(size, pvc.Name+ "-clone", k8sv1.PersistentVolumeBlock, tests.StorageClass, "PersistentVolumeClaim", pvc.Name)

nbalacha · 2022-07-08T06:38:42Z

e2e/lvm/pvc_test.go

+				fmt.Printf("Cloned PVC %s is bound\n", clonePvc.Name)
+
+				By("Restore Snapshot for file-pvc")
+				restorePvc = tests.GetSamplePvc(size, pvc.Name, k8sv1.PersistentVolumeFilesystem, tests.StorageClass, snapshot.Name, pvc.Name)


Suggested change

restorePvc = tests.GetSamplePvc(size, pvc.Name, k8sv1.PersistentVolumeFilesystem, tests.StorageClass, snapshot.Name, pvc.Name)

restorePvc = tests.GetSamplePvc(size, pvc.Name + "-restore", k8sv1.PersistentVolumeFilesystem, tests.StorageClass, snapshot.Name, pvc.Name)

nbalacha · 2022-07-08T06:39:10Z

e2e/lvm/pvc_test.go

+				fmt.Printf("Cloned PVC %s is bound\n", clonePvc.Name)
+
+				By("Restore Snapshot for block-pvc")
+				restorePvc = tests.GetSamplePvc(size, pvc.Name, k8sv1.PersistentVolumeBlock, tests.StorageClass, snapshot.Name, pvc.Name)


Suggested change

restorePvc = tests.GetSamplePvc(size, pvc.Name, k8sv1.PersistentVolumeBlock, tests.StorageClass, snapshot.Name, pvc.Name)

restorePvc = tests.GetSamplePvc(size, pvc.Name+"-restore", k8sv1.PersistentVolumeBlock, tests.StorageClass, snapshot.Name, pvc.Name)

nbalacha · 2022-07-08T06:50:12Z

e2e/testdata.go

+	}
+	pvc := &k8sv1.PersistentVolumeClaim{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      name + kindName,


Suggested change

Name: name + kindName,

Name: name ,

nbalacha · 2022-07-08T08:07:24Z

e2e/testdata.go

@@ -61,3 +41,54 @@ func GetSamplePod(name, pvcName string) *k8sv1.Pod {
 	}
 	return pod
 }
+
+// GetSampleVolumeSnapshot creates and returns the VolumeSnapshot for the provided PVC.
+func GetSampleVolumeSnapshot(sourceName string, storageClass string) *snapapi.VolumeSnapshot {


Suggested change

func GetSampleVolumeSnapshot(sourceName string, storageClass string) *snapapi.VolumeSnapshot {

func GetSampleVolumeSnapshot(snapshotName, sourceName string, storageClass string) *snapapi.VolumeSnapshot {

nbalacha · 2022-07-08T08:07:43Z

e2e/testdata.go

+func GetSampleVolumeSnapshot(sourceName string, storageClass string) *snapapi.VolumeSnapshot {
+	vs := &snapapi.VolumeSnapshot{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      sourceName,


Suggested change

Name: sourceName,

Name: snapshotName,

riya-singhal31 · 2022-07-08T08:31:37Z

Thanks @nbalacha. Addressed all the reviews.

nbalacha · 2022-07-08T10:51:22Z

e2e/lvm/pvc_test.go

+				fmt.Printf("Cloned PVC %s is bound\n", clonePvc.Name)
+
+				By("Restore Snapshot for block-pvc")
+				restorePvc = tests.GetSamplePvc(size, pvc.Name+"-restore", k8sv1.PersistentVolumeBlock, tests.StorageClass, snapshot.Name, pvc.Name)


This doesn't look right - shouldn't it be

Suggested change

restorePvc = tests.GetSamplePvc(size, pvc.Name+"-restore", k8sv1.PersistentVolumeBlock, tests.StorageClass, snapshot.Name, pvc.Name)

restorePvc = tests.GetSamplePvc(size, pvc.Name+"-restore", k8sv1.PersistentVolumeBlock, tests.StorageClass, "VolumeSnapshot", snapshot.Name)

nbalacha · 2022-07-08T10:54:57Z

e2e/lvm/pvc_test.go

+				fmt.Printf("Cloned PVC %s is bound\n", clonePvc.Name)
+
+				By("Restore Snapshot for file-pvc")
+				restorePvc = tests.GetSamplePvc(size, pvc.Name+"-restore", k8sv1.PersistentVolumeFilesystem, tests.StorageClass, snapshot.Name, pvc.Name)


Suggested change

restorePvc = tests.GetSamplePvc(size, pvc.Name+"-restore", k8sv1.PersistentVolumeFilesystem, tests.StorageClass, snapshot.Name, pvc.Name)

restorePvc = tests.GetSamplePvc(size, pvc.Name+"-restore", k8sv1.PersistentVolumeFilesystem, tests.StorageClass, "VolumeSnapshot", pvc.Name)

nbalacha · 2022-07-08T11:10:01Z

e2e/testdata.go

+	if sourceType != "" && sourceName != "" {
+		pvc.Spec.DataSource = &k8sv1.TypedLocalObjectReference{
+			Name: sourceName,
+			Kind: sourceType,
+		}
+	}


Suggested change

if sourceType != "" && sourceName != "" {

pvc.Spec.DataSource = &k8sv1.TypedLocalObjectReference{

Name: sourceName,

Kind: sourceType,

}

}

if sourceType != "" && sourceName != "" {

if sourceType == "VolumeSnapshot" {

pvc.Spec.DataSource = &k8sv1.TypedLocalObjectReference{

Name: sourceName,

Kind: sourceType,

ApiGroup: "snapshot.storage.k8s.io"

}

} else {

pvc.Spec.DataSource = &k8sv1.TypedLocalObjectReference{

Name: sourceName,

Kind: sourceType,

}

}

}

Signed-off-by: riya-singhal31 <[email protected]>

riya-singhal31 · 2022-07-08T12:48:38Z

For file system:
[riyasinghal@fedora lvm-operator]$ oc get pvc,pods -n lvm-endtoendtest
NAME STATUS VOLUME CAPACITY ACCESS MODES STORAGECLASS AGE
persistentvolumeclaim/lvmfilepvc Bound pvc-c4f7eee1-669f-4cdc-b24a-dad92d65243a 5Gi RWO odf-lvm-vg1 115s
persistentvolumeclaim/lvmfilepvc-clone Bound pvc-f513e931-911a-4737-b439-c6e8f850a6f5 5Gi RWO odf-lvm-vg1 84s
persistentvolumeclaim/lvmfilepvc-restore Bound pvc-e1d6d5fa-ce66-4b5c-822a-25da12dd49f9 5Gi RWO odf-lvm-vg1 54s

NAME READY STATUS RESTARTS AGE
pod/clone-lvmfilepod 1/1 Running 0 84s
pod/lvmfilepod 1/1 Running 0 115s
pod/restore-lvmfilepod 1/1 Running 0 54s

[riyasinghal@fedora lvm-operator]$ oc get vs -n lvm-endtoendtest
NAME READYTOUSE SOURCEPVC SOURCESNAPSHOTCONTENT RESTORESIZE SNAPSHOTCLASS SNAPSHOTCONTENT CREATIONTIME AGE
lvmfilepvc-snapshot true lvmfilepvc 5Gi odf-lvm-vg1 snapcontent-2ed9ef99-a30c-4672-9676-509c6307f823 11m 11m

For block:
[riyasinghal@fedora lvm-operator]$ oc get pvc,pods -n lvm-endtoendtest
NAME STATUS VOLUME CAPACITY ACCESS MODES STORAGECLASS AGE
persistentvolumeclaim/lvmblockpvc Bound pvc-bd631014-a9a2-4cb5-83e6-4c65ce74f1aa 5Gi RWO odf-lvm-vg1 112s
persistentvolumeclaim/lvmblockpvc-clone Bound pvc-3c5b8ee3-fdaf-4a20-b416-a484072f8076 5Gi RWO odf-lvm-vg1 81s
persistentvolumeclaim/lvmblockpvc-restore Bound pvc-219028eb-8123-4d62-8ed5-c6d966c81786 5Gi RWO odf-lvm-vg1 51s

NAME READY STATUS RESTARTS AGE
pod/clone-lvmblockpod 1/1 Running 0 81s
pod/lvmblockpod 1/1 Running 0 112s
pod/restore-lvmblockpod 1/1 Running 0 51s

[riyasinghal@fedora lvm-operator]$ oc get vs
NAME READYTOUSE SOURCEPVC SOURCESNAPSHOTCONTENT RESTORESIZE SNAPSHOTCLASS SNAPSHOTCONTENT CREATIONTIME AGE
lvmblockpvc-snapshot true lvmblockpvc 5Gi odf-lvm-vg1 snapcontent-feef9e3f-e215-4520-aade-097c33ac4032 2m50s 2m50s

openshift-ci · 2022-07-08T12:56:40Z

@riya-singhal31: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/lvm-operator-bundle-e2e-aws	`8d00bb5`	link	false	`/test lvm-operator-bundle-e2e-aws`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-07-08T13:19:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nbalacha, riya-singhal31, sp98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nbalacha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2022

riya-singhal31 changed the title ~~[WIP]test: added check for snapshot creation in e2e~~ test: added check for snapshot creation in e2e Jun 13, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2022

riya-singhal31 force-pushed the snapshot-clone branch from 7c32b3e to ef8877d Compare June 15, 2022 12:28

riya-singhal31 changed the title ~~test: added check for snapshot creation in e2e~~ [WIP]test: added check for snapshot creation in e2e Jun 15, 2022

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2022

riya-singhal31 changed the title ~~[WIP]test: added check for snapshot creation in e2e~~ [WIP]test: added check for snapshot and clone creation in e2e Jun 15, 2022

nbalacha suggested changes Jun 16, 2022

View reviewed changes

openshift-ci bot assigned nbalacha Jun 16, 2022

riya-singhal31 force-pushed the snapshot-clone branch from ef8877d to 8c6d726 Compare June 17, 2022 06:48

riya-singhal31 changed the title ~~[WIP]test: added check for snapshot and clone creation in e2e~~ test: added check for snapshot and clone creation in e2e Jun 17, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2022

sp98 suggested changes Jun 17, 2022

View reviewed changes

openshift-ci bot assigned sp98 Jun 17, 2022

riya-singhal31 force-pushed the snapshot-clone branch from 8c6d726 to b1d7953 Compare June 17, 2022 08:28

sp98 approved these changes Jun 21, 2022

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2022

riya-singhal31 force-pushed the snapshot-clone branch from b1d7953 to 0d7d3ad Compare June 22, 2022 08:01

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2022

nbalacha suggested changes Jun 24, 2022

View reviewed changes

riya-singhal31 force-pushed the snapshot-clone branch from 0d7d3ad to 704166e Compare June 27, 2022 12:55

riya-singhal31 force-pushed the snapshot-clone branch from 704166e to 4b332bc Compare June 27, 2022 13:00

nbalacha reviewed Jun 28, 2022

View reviewed changes

nbalacha suggested changes Jun 28, 2022

View reviewed changes

riya-singhal31 force-pushed the snapshot-clone branch from 4b332bc to f30be35 Compare June 30, 2022 07:06

nbalacha suggested changes Jul 7, 2022

View reviewed changes

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2022

Merge branch 'main' of github.com:riya-singhal31/lvm-operator into sn…

2e57965

…apshot-clone

riya-singhal31 force-pushed the snapshot-clone branch from 3b9891d to 2e57965 Compare July 7, 2022 10:24

riya-singhal31 requested a review from nbalacha July 7, 2022 10:25

riya-singhal31 force-pushed the snapshot-clone branch 2 times, most recently from 1bd9d79 to 534bc51 Compare July 8, 2022 05:56

nbalacha reviewed Jul 8, 2022

View reviewed changes

riya-singhal31 force-pushed the snapshot-clone branch from 534bc51 to 3252962 Compare July 8, 2022 08:21

riya-singhal31 requested a review from nbalacha July 8, 2022 08:31

riya-singhal31 force-pushed the snapshot-clone branch from 3252962 to e815090 Compare July 8, 2022 08:35

nbalacha reviewed Jul 8, 2022

View reviewed changes

test: added check for snapshot and clone creation

8d00bb5

Signed-off-by: riya-singhal31 <[email protected]>

riya-singhal31 force-pushed the snapshot-clone branch from e815090 to 8d00bb5 Compare July 8, 2022 12:28

nbalacha approved these changes Jul 8, 2022

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2022

openshift-ci bot merged commit 4de23c2 into openshift:main Jul 8, 2022

	filePvc = tests.GetSamplePVC(tests.StorageClass, quantity, "lvmfilepvc", k8sv1.PersistentVolumeFilesystem)
	filePvc = tests.GetSamplePVC(tests.StorageClass, size, "lvmfilepvc", k8sv1.PersistentVolumeFilesystem)

	By("PVC(file system) Should be bound and Pod should be running")
	By("Verifying that the PVC(file system) is bound and the Pod is running")

	By("Snapshot for file-pvc")
	By("Creating a Snapshot of the file-pvc")

	err = tests.DeployManagerObj.GetCrClient().Delete(context.TODO(), blockPvcRestore)
	err = tests.DeployManagerObj.GetCrClient().Delete(context.TODO(), restoreBlockPod)

	func GetSampleClone(quantity, name string, volumemode k8sv1.PersistentVolumeMode, storageClass string) *k8sv1.PersistentVolumeClaim {
	func GetSampleClone(size, name string, volumemode k8sv1.PersistentVolumeMode, storageClass string) *k8sv1.PersistentVolumeClaim {

	func GetRestoreVolume(quantity, name string, storageClass string) *k8sv1.PersistentVolumeClaim {
	func GetRestoreVolume(size, name string, storageClass string) *k8sv1.PersistentVolumeClaim {

	test := tests.DeployManagerObj.GetCrClient()
	client := tests.DeployManagerObj.GetCrClient()

	func GetSampleVolumeSnapshot(name string, storageClass string) *snapapi.VolumeSnapshot {
	func GetSampleVolumeSnapshot(name string, storageClass string, sourceName string) *snapapi.VolumeSnapshot {

	PersistentVolumeClaimName: &name,
	PersistentVolumeClaimName: &sourceName,

	clonePvc = tests.GetSamplePvc(size, pvc.Name, k8sv1.PersistentVolumeFilesystem, tests.StorageClass, "PersistentVolumeClaim", pvc.Name)
	clonePvc = tests.GetSamplePvc(size, pvc.Name + "-clone", k8sv1.PersistentVolumeFilesystem, tests.StorageClass, "PersistentVolumeClaim", pvc.Name)

	restorePvc = tests.GetSamplePvc(size, pvc.Name, k8sv1.PersistentVolumeFilesystem, tests.StorageClass, snapshot.Name, pvc.Name)
	restorePvc = tests.GetSamplePvc(size, pvc.Name + "-restore", k8sv1.PersistentVolumeFilesystem, tests.StorageClass, snapshot.Name, pvc.Name)

	func GetSampleVolumeSnapshot(sourceName string, storageClass string) *snapapi.VolumeSnapshot {
	func GetSampleVolumeSnapshot(snapshotName, sourceName string, storageClass string) *snapapi.VolumeSnapshot {

test: added check for snapshot and clone creation in e2e #206

test: added check for snapshot and clone creation in e2e #206

Conversation

riya-singhal31 commented Jun 13, 2022 • edited Loading

nbalacha left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riya-singhal31 commented Jun 22, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riya-singhal31 commented Jun 27, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nbalacha Jun 28, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nbalacha left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nbalacha Jul 8, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riya-singhal31 commented Jul 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riya-singhal31 commented Jul 8, 2022

openshift-ci bot commented Jul 8, 2022

openshift-ci bot commented Jul 8, 2022

riya-singhal31 commented Jun 13, 2022 •

edited

Loading

riya-singhal31 commented Jun 22, 2022 •

edited

Loading

nbalacha Jun 28, 2022 •

edited

Loading

nbalacha Jul 8, 2022 •

edited

Loading