-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the recommended k8s labels to lvmo pods #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to update the selector labels in the service as well
controllers/defaults.go
Outdated
TopolvmControllerLabelVal = "topolvm-controller" | ||
TopolvmNodeLabelVal = "topolvm-node" | ||
VGManagerLabelVal = "vg-manager" | ||
ManagedByLabelValue = "lvm-operator" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some variables end with val
and some with value
. We should make it consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
// labels and values | ||
|
||
// AppKubernetesPartOfLabel is the Kubernetes recommended part-of label | ||
AppKubernetesPartOfLabel = "app.kubernetes.io/part-of" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit. Label keys could end with with key
. AppKubernetesPartOfLabelKey
or PartOfLabelKey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can leave it as it is.
This commit adds the recommended k8s labels listed in the link https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels to the pods and services. Other resources will be labeled in the future. Signed-off-by: N Balachandran <[email protected]>
This commit updates the bundle manifests with the newly added recommended kubernetes labels. Signed-off-by: N Balachandran <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nbalacha, sp98 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.11 |
@nbalacha: #217 failed to apply on top of branch "release-4.11":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.