-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the LogicalVolumes.topolvm.cybozu.com CRD. #224
Conversation
served: true | ||
storage: true | ||
subresources: | ||
status: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status does not match with what is there in the upstream topolvm.
@@ -1,5 +1,3 @@ | |||
|
|||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep the ---
at the beginning. Looks like a very common practice to begin the yaml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why there is a huge diff in both the files, I think they should contain the same change?
This commit updates the LogicalVolume CRD with the new Topolvm Snapshot and Clone changes. Signed-off-by: N Balachandran <[email protected]>
Updates the bundle manifests with the changed LogicalVolume CRD. Signed-off-by: N Balachandran <[email protected]>
Mostly due to text alignment change of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, nbalacha, sp98 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.11 |
@nbalacha: new pull request created: #225 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Updates the LVMO manifests with the modified LogicalVolumes.topolvm.cybozu.com CRD.