Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the LogicalVolumes.topolvm.cybozu.com CRD. #224

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Update the LogicalVolumes.topolvm.cybozu.com CRD. #224

merged 2 commits into from
Jul 5, 2022

Conversation

nbalacha
Copy link
Contributor

@nbalacha nbalacha commented Jul 5, 2022

Updates the LVMO manifests with the modified LogicalVolumes.topolvm.cybozu.com CRD.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2022
served: true
storage: true
subresources:
status: {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status does not match with what is there in the upstream topolvm.

@@ -1,5 +1,3 @@

---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep the --- at the beginning. Looks like a very common practice to begin the yaml.

Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there is a huge diff in both the files, I think they should contain the same change?

This commit updates the LogicalVolume CRD with the
new Topolvm Snapshot and Clone changes.

Signed-off-by: N Balachandran <[email protected]>
Updates the bundle manifests with the changed LogicalVolume
CRD.

Signed-off-by: N Balachandran <[email protected]>
@sp98
Copy link
Contributor

sp98 commented Jul 5, 2022

Why there is a huge diff in both the files, I think they should contain the same change?

Mostly due to text alignment change of the description. Should be ok.

@nbalacha nbalacha requested review from iamniting and sp98 July 5, 2022 14:42
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2022
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, nbalacha, sp98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit ee4263a into openshift:main Jul 5, 2022
@nbalacha
Copy link
Contributor Author

nbalacha commented Jul 5, 2022

/cherry-pick release-4.11

@openshift-cherrypick-robot

@nbalacha: new pull request created: #225

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nbalacha nbalacha deleted the bug-2103818 branch October 11, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants