Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-606: fix: reenable falsly disabled integration tests #373

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

jakobmoellerdev
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev commented Aug 1, 2023

This enables the test suites that were disabled in 3ce11a8 back in may by accident. Potentially the ginkgo logs could cause issues in pipeline parsers if the stdout is parsed, not sure if that changed since then. Other than that it should run fine

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2023

@jakobmoellerdev: This pull request references OCPVE-606 which is a valid jira issue.

In response to this:

This enables the test suites that were disabled in jakobmoellerdev@3ce11a8 back in may by accident. Potentially the ginkgo logs could cause issues in pipeline parsers if the stdout is parsed, not sure if that changed since then. Other than that it should run fine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 1, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2023

@jakobmoellerdev: This pull request references OCPVE-606 which is a valid jira issue.

In response to this:

This enables the test suites that were disabled in 3ce11a8 back in may by accident. Potentially the ginkgo logs could cause issues in pipeline parsers if the stdout is parsed, not sure if that changed since then. Other than that it should run fine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 1, 2023
@openshift-ci openshift-ci bot requested review from jerpeter1 and qJkee August 1, 2023 13:29
@codecov-commenter
Copy link

Codecov Report

Merging #373 (d0f4189) into main (a962b90) will increase coverage by 40.12%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #373       +/-   ##
===========================================
+ Coverage   16.59%   56.72%   +40.12%     
===========================================
  Files          24       24               
  Lines        2061     2061               
===========================================
+ Hits          342     1169      +827     
+ Misses       1693      809      -884     
- Partials       26       83       +57     

see 11 files with indirect coverage changes

@jeff-roche
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@qJkee
Copy link
Contributor

qJkee commented Aug 1, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b50e222 into openshift:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants