Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-624: fix: improve logging around device path validation #379

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

jeff-roche
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 10, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 10, 2023

@jeff-roche: This pull request references OCPVE-624 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 10, 2023
@jeff-roche
Copy link
Contributor Author

/hold for review
/cc @suleymanakbas91 @jakobmoellerdev @qJkee

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 10, 2023
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #379 (b17f182) into main (a962b90) will increase coverage by 40.33%.
Report is 8 commits behind head on main.
The diff coverage is 59.52%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #379       +/-   ##
===========================================
+ Coverage   16.59%   56.93%   +40.33%     
===========================================
  Files          24       25        +1     
  Lines        2061     2099       +38     
===========================================
+ Hits          342     1195      +853     
+ Misses       1693      820      -873     
- Partials       26       84       +58     
Files Changed Coverage Δ
pkg/cluster/leaderelection.go 57.57% <57.57%> (ø)
pkg/vgmanager/devices.go 72.86% <66.66%> (-1.33%) ⬇️

... and 11 files with indirect coverage changes

pkg/vgmanager/devices.go Outdated Show resolved Hide resolved
pkg/vgmanager/devices.go Outdated Show resolved Hide resolved
pkg/vgmanager/devices.go Outdated Show resolved Hide resolved
pkg/vgmanager/devices.go Outdated Show resolved Hide resolved
pkg/vgmanager/devices.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
@qJkee
Copy link
Contributor

qJkee commented Aug 10, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
@jeff-roche
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

@jeff-roche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 259c22f into openshift:main Aug 10, 2023
@jeff-roche jeff-roche deleted the devicePathLogging branch August 10, 2023 14:42
@jeff-roche
Copy link
Contributor Author

/cherry-pick release-4.14

@openshift-cherrypick-robot

@jeff-roche: new pull request created: #390

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants